-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] collaborative: snapshot when leaving spreadsheet
Purpose ------- Let's say a user works a lot on a spreadsheet and performs a lot of heavy operations generating very large revisions (with lots of commands), such as copy-pasting a very large zone (there's one UPDATE_CELL command per copy-pasted cell) If the user does multiple such very large revision, one after the other, every thing is fine client side. The next time the spreadsheet is open though: the server needs to load all those revisions to send them to the client. The revisions can be so large it can blow up the server memory limit. The spreadsheet cannot be open anymore. Solution -------- The solution proposed here is to snapshot the spreadsheet when the client leaves the spreadsheet. Next time the spreadsheet is open, the snapshot will be loaded, and not the revivisions. There's a catch: snapshotting a spreadsheet kills the local history (CTRL+Z). For this reason, we only snapshot if there's no other connected client as it would kill the other users history. closes #4411 Task: 3940465 X-original-commit: 7bcff34 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
- Loading branch information
1 parent
5d0afe2
commit 7801425
Showing
3 changed files
with
60 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters