Skip to content

odoo/odoo

16.0
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?
85 branches 0 tags
Code

Latest commit

@pivi-odoo
pivi-odoo [FIX] sale: correct disabling of attr. for archived variants
4114418 Jun 9, 2023
[FIX] sale: correct disabling of attr. for archived variants 
Current behaviour:
In the context that a variant is being archived after the removal of
one of it's attribute lines, on the e-commerce product's page of
said product some of the attribute values are disabled because they
were part of the archived variant.

Expected behaviour:
Archiving a variant due to removal of an attribute line shouldn't
disable the selection of the other attributes on the e-commerce
product's page of the product, since the variant can never be
reconstituted (the current selection of attributes lines is `X-1`,
where `X` is the number of attribute lines of the archived variant).

Steps to reproduce:
- Install eCommerce,
- Create a product with 2 attribute lines and add values A1,A2 and
  B1,B2 respectively, 4 variants should be created (cross-product).
- Go on the e-commerce product's page of the product, add the
  variant A2,B1 to the cart
- Go in the backend, delete attribute line (B1,B2), from the product
  template
- Go back on the e-commerce product's page, the option with A2 is
  disabled.

Reason for the problem:
When deleting an attribute line from a `product.template`, if one of
the variant is being used somewhere (in our case as a `sale.order.
line` of the cart), it is archived instead of deleted. This means
that when loading the page of the product with send the attribute
values of the archived products, so we can disable the selection of
the attributes that would make the archived variant. Since A2 is
part of the variant A2,B1 that was archived, we disable the
selection for A2, without taking into account that we don't have the
same number of attributes than the archived variant and it is
impossible to make the archived variant from the e-commerce
product's page.

Fix:
Restrain the condition that checks for which attributes to disable.
We make sure that we have *any* common part of the selection to the
archived variant, and we also make sure the count of the attributes
for the product is the same as the archived variant we are checking
against.

Affected versions:
- 16.0
- saas-16.1
- saas-16.2
- saas-16.3
- master

opw-3329225

closes #124344

Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>
4114418

Git stats

Files

Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
.github
[FIX] core: use proper break (hr) in PR template footer
September 26, 2022 16:59
.tx
[IMP] *: export 16.0 source terms
May 23, 2023 16:02
addons
[FIX] sale: correct disabling of attr. for archived variants
June 9, 2023 15:26
debian
[IMP] tests: refactor unittest classes
February 28, 2023 10:54
doc/cla
[CLA] signature for flalexg
June 9, 2023 07:28
odoo
[FIX] base: Add exception info to logger.error
June 9, 2023 15:26
setup
[ADD] hw_*: Add python modules for using Samba
February 16, 2023 20:22
.gitignore
[FIX] dx: port back js tooling gitignore properties
December 1, 2022 08:11
CONTRIBUTING.md
[FIX] CONTRIBUTING.md: update template link to V16
October 17, 2022 10:41
COPYRIGHT
[LEGAL] Use global LICENSE/COPYRIGHT files, remove boilerplate text
June 2, 2015 03:16
LICENSE
[LEGAL] Switch to LGPLv3 License
September 8, 2015 17:58
MANIFEST.in
[FIX] packaging: include all odoo files in src build
March 1, 2021 17:25
README.md
[FIX] *: retarget documentation links to 16.0
October 17, 2022 12:37
SECURITY.md
[FIX] SECURITY.md: deprecate 13.0
October 17, 2022 10:41
odoo-bin
[FIX] namespace packages: move from pkg_resources-style to pkg_util
September 18, 2017 16:05
requirements.txt
[FIX] requirements.txt: unpin pytz
April 30, 2023 09:18
setup.cfg
[FIX] packaging: set fedora 36 as base for rpm
October 10, 2022 11:17
setup.py
[FIX] packaging: set fedora 36 as base for rpm
October 10, 2022 11:17
Odoo Getting started with Odoo

README.md

Build Status Tech Doc Help Nightly Builds

Odoo

Odoo is a suite of web based open source business apps.

The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...

Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.

Getting started with Odoo

For a standard installation please follow the Setup instructions from the documentation.

To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials

About

Odoo. Open Source Apps To Grow Your Business.

www.odoo.com

Topics

python business erp apps management odoo odoo-apps

Resources

Readme

License

View license

Security policy

Security policy

Stars

29.4k stars

Watchers

1.5k watching

Forks

18.8k forks
Report repository

Contributors 1,682

+ 1,671 contributors

Languages