From 3cd0e471980c1a08e6d8970ba71f1dc070c69144 Mon Sep 17 00:00:00 2001
From: Mohammed Shekha <msh@openerp.com>
Date: Mon, 21 May 2018 10:54:29 +0530
Subject: [PATCH] [IMP] Improvements

---
 .../static/src/js/reconciliation/reconciliation_renderer.js  | 2 +-
 addons/base_setup/data/base_setup_data.xml                   | 4 ++--
 addons/base_setup/models/ir_http.py                          | 2 +-
 addons/base_setup/models/res_config_settings.py              | 2 +-
 addons/base_setup/views/res_config_settings_views.xml        | 4 ++--
 addons/web/models/ir_http.py                                 | 2 +-
 addons/web/static/src/js/chrome/abstract_web_client.js       | 5 ++++-
 7 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/addons/account/static/src/js/reconciliation/reconciliation_renderer.js b/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
index ed9f6b258ebff..c183a1e00ae8b 100644
--- a/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
+++ b/addons/account/static/src/js/reconciliation/reconciliation_renderer.js
@@ -123,7 +123,7 @@ var StatementRenderer = Widget.extend(FieldManagerMixin, {
             $done.find('.button_back_to_statement').click(this._onGoToBankStatement.bind(this));
             this.$el.children().hide();
             // display rainbowman after full reconciliation
-            if (session.show_rainbowman) {
+            if (session.show_effect) {
                 this.trigger_up('show_effect', {
                     type: 'rainbow_man',
                     fadeout: 'no',
diff --git a/addons/base_setup/data/base_setup_data.xml b/addons/base_setup/data/base_setup_data.xml
index dab8938dc3d0f..6499d00add477 100644
--- a/addons/base_setup/data/base_setup_data.xml
+++ b/addons/base_setup/data/base_setup_data.xml
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
     <data noupdate="1">
-        <record model="ir.config_parameter" id="show_rainbowman">
-            <field name="key">base_setup.show_rainbowman</field>
+        <record model="ir.config_parameter" id="show_effect">
+            <field name="key">base_setup.show_effect</field>
             <field name="value">True</field>
         </record>
     </data>
diff --git a/addons/base_setup/models/ir_http.py b/addons/base_setup/models/ir_http.py
index 194f3af724374..f65384adfc12e 100644
--- a/addons/base_setup/models/ir_http.py
+++ b/addons/base_setup/models/ir_http.py
@@ -9,5 +9,5 @@ class IrHttp(models.AbstractModel):
 
     def session_info(self):
         result = super(IrHttp, self).session_info()
-        result['show_rainbowman'] = request.env['ir.config_parameter'].sudo().get_param('base_setup.show_rainbowman')
+        result['show_effect'] = request.env['ir.config_parameter'].sudo().get_param('base_setup.show_effect')
         return result
diff --git a/addons/base_setup/models/res_config_settings.py b/addons/base_setup/models/res_config_settings.py
index ee796c8f0e2d0..7093634dd4b21 100644
--- a/addons/base_setup/models/res_config_settings.py
+++ b/addons/base_setup/models/res_config_settings.py
@@ -40,7 +40,7 @@ class ResConfigSettings(models.TransientModel):
             help="Allows to work in a multi currency environment")
     paperformat_id = fields.Many2one(related="company_id.paperformat_id", string='Paper format')
     external_report_layout = fields.Selection(related="company_id.external_report_layout")
-    show_rainbowman = fields.Boolean(string="Rainbow Gamification", config_parameter='base_setup.show_rainbowman')
+    show_effect = fields.Boolean(string="Show Effect", config_parameter='base_setup.show_effect')
 
     @api.model
     def get_values(self):
diff --git a/addons/base_setup/views/res_config_settings_views.xml b/addons/base_setup/views/res_config_settings_views.xml
index 61789689f3650..3f18f699f8acf 100644
--- a/addons/base_setup/views/res_config_settings_views.xml
+++ b/addons/base_setup/views/res_config_settings_views.xml
@@ -80,10 +80,10 @@
                             </div>
                             <div class="col-xs-12 col-md-6 o_setting_box" groups="base.group_no_one">
                                 <div class="o_setting_left_pane">
-                                    <field name="show_rainbowman"/>
+                                    <field name="show_effect"/>
                                 </div>
                                 <div class="o_setting_right_pane">
-                                    <label for="show_rainbowman"/>
+                                    <label for="show_effect"/>
                                     <div class="text-muted">
                                         Add fun feedback and motivate your employees
                                     </div>
diff --git a/addons/web/models/ir_http.py b/addons/web/models/ir_http.py
index 0a0ea6ff4c995..9d8494ce68568 100644
--- a/addons/web/models/ir_http.py
+++ b/addons/web/models/ir_http.py
@@ -39,7 +39,7 @@ def session_info(self):
             "user_companies": {'current_company': (user.company_id.id, user.company_id.name), 'allowed_companies': [(comp.id, comp.name) for comp in user.company_ids]} if display_switch_company_menu else False,
             "currencies": self.get_currencies(),
             "web.base.url": self.env['ir.config_parameter'].sudo().get_param('web.base.url', default=''),
-            'show_rainbowman': True
+            "show_effect": True
         }
 
     def get_currencies(self):
diff --git a/addons/web/static/src/js/chrome/abstract_web_client.js b/addons/web/static/src/js/chrome/abstract_web_client.js
index 233e7d7d34429..4b455a7b7381a 100644
--- a/addons/web/static/src/js/chrome/abstract_web_client.js
+++ b/addons/web/static/src/js/chrome/abstract_web_client.js
@@ -389,8 +389,11 @@ var AbstractWebClient = Widget.extend(ServiceProviderMixin, {
         var data = e.data || {};
         var type = data.type || 'rainbow_man';
         if (type === 'rainbow_man') {
-            if (session.show_rainbowman) {
+            if (session.show_effect) {
                 new RainbowMan(data).appendTo(this.$el);
+            } else {
+                // For instance keep title blank, as we don't have title in data
+                this.notification_manager.notify('', data.message, true);
             }
         } else {
             throw new Error('Unknown effect type: ' + type);