Skip to content
Browse files

[FIX] stop the FSWatcher when stopping the server

Avoid potential tracebacks from the FSWatcher's thread being killed.

Drawback: Server shut down can have an extra small delay

(only applies when the --dev=reload option is given)

closes #31855

Signed-off-by: Christophe Simonis <>
  • Loading branch information...
Icallhimtest committed Mar 14, 2019
1 parent 7b6cfc4 commit 744bdd275eff08fe7593dd8ca7aa9162b54ab275
Showing with 2 additions and 2 deletions.
  1. +2 −2 odoo/service/
@@ -1019,10 +1019,10 @@ def start(preload=None, stop=False):

rc =, stop)

if watcher:
# like the legend of the phoenix, all ends with beginnings
if getattr(odoo, 'phoenix', False):
if watcher:

return rc if rc else 0

0 comments on commit 744bdd2

Please sign in to comment.
You can’t perform that action at this time.