From 75af6c56842c323d3c63bd8d59ecd289a5caf6d5 Mon Sep 17 00:00:00 2001
From: abd-msyukyu-odoo <abd@odoo.com>
Date: Wed, 27 Mar 2024 13:53:13 +0100
Subject: [PATCH] [FIX] web: adapt z-index and dimensions of properties field
 types
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In [1], dropdowns were updated and it impacted the properties field edition:
- z-index of the popover opened for the dropdown of a property field type was
  lower than the element it was opened for, resulting in part of the popover
  being hidden.
- img style (dimensions) was not applied as the dropdown list is now a popover
  (sibling instead of child), resulting in bigger images.

This commit fixes the issue by adding a class on the field type selection
popover.

[1]: https://github.com/odoo/odoo/commit/7b7a2613901de20791d111a8efc8e98c226f39ad

task-3834506

closes odoo/odoo#159686

X-original-commit: f202f6fd6aee9d4f5dcd532ab0b4f74253e4635f
Related: odoo/enterprise#59649
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
---
 .../src/views/fields/properties/property_definition.scss | 9 +++++++++
 .../src/views/fields/properties/property_definition.xml  | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/src/views/fields/properties/property_definition.scss b/addons/web/static/src/views/fields/properties/property_definition.scss
index 9c4142d8569d8..493285d9a0e1c 100644
--- a/addons/web/static/src/views/fields/properties/property_definition.scss
+++ b/addons/web/static/src/views/fields/properties/property_definition.scss
@@ -64,3 +64,12 @@
         }
     }
 }
+
+.o_field_property_definition_type_popover.popover {
+    z-index: $zindex-popover;
+
+    .dropdown-item img {
+        width: 20px;
+        height: 20px;
+    }
+}
diff --git a/addons/web/static/src/views/fields/properties/property_definition.xml b/addons/web/static/src/views/fields/properties/property_definition.xml
index 9c2851d311348..d163c9826859e 100644
--- a/addons/web/static/src/views/fields/properties/property_definition.xml
+++ b/addons/web/static/src/views/fields/properties/property_definition.xml
@@ -53,7 +53,7 @@
                                 t-attf-src="/web/static/src/views/fields/properties/icons/{{state.propertyDefinition.type}}.png"/>
                             <span t-out="state.typeLabel"/>
                         </div>
-                        <Dropdown t-else="">
+                        <Dropdown menuClass="'o_field_property_definition_type_popover'" t-else="">
                             <button class="btn btn-link d-flex p-0 w-100" t-att-title="state.typeLabel">
                                 <div class="o_input_dropdown w-100 o_field_property_dropdown">
                                     <img t-attf-src="/web/static/src/views/fields/properties/icons/{{state.propertyDefinition.type}}.png"