Permalink
Browse files

[FIX] l10n_es: apply correct type to each account.

  • Loading branch information...
oco-odoo committed Sep 13, 2018
1 parent cbdb738 commit 7dc13e237cf7860fa7490920322c9416456f1b93
Showing with 81 additions and 81 deletions.
  1. +81 −81 addons/l10n_es/account_account_common.xml
Oops, something went wrong.

5 comments on commit 7dc13e2

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Sep 13, 2018

Contributor

@oco-odoo from where are these changes based?

Contributor

pedrobaeza replied Sep 13, 2018

@oco-odoo from where are these changes based?

@oco-odoo

This comment has been minimized.

Show comment
Hide comment
@oco-odoo

oco-odoo Sep 18, 2018

Contributor

@pedrobaeza We got feedback about them from one of our customers ;)

Contributor

oco-odoo replied Sep 18, 2018

@pedrobaeza We got feedback about them from one of our customers ;)

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Sep 18, 2018

Contributor

Yeah, but this kind of thing must be checked at least with me as leader of the OCA Spanish Localization PSC, now that we have converged both l10n_es (OCA and Odoo) in one. And not only that, that customer (which I suspect who is) haven't made any contribution, but they are relied as a trusted source for this information?

This even had a PR for being discussed, or am I mistaken?

I haven't dug enough yet, but changing reconcile flag of some accounts is not a good idea when updating chart of accounts (via account_chart_update module) when you already have journal items, and not only that, it impacts on the statement workflow, presenting accounts that can be inconvenient to be shown (and this for all users - on new chart of accounts or existing ones -).

I think this should be planned in other way and discussed with whole Spanish community (or at least those of them that wants to participate). @qdp-odoo what do you think?

Contributor

pedrobaeza replied Sep 18, 2018

Yeah, but this kind of thing must be checked at least with me as leader of the OCA Spanish Localization PSC, now that we have converged both l10n_es (OCA and Odoo) in one. And not only that, that customer (which I suspect who is) haven't made any contribution, but they are relied as a trusted source for this information?

This even had a PR for being discussed, or am I mistaken?

I haven't dug enough yet, but changing reconcile flag of some accounts is not a good idea when updating chart of accounts (via account_chart_update module) when you already have journal items, and not only that, it impacts on the statement workflow, presenting accounts that can be inconvenient to be shown (and this for all users - on new chart of accounts or existing ones -).

I think this should be planned in other way and discussed with whole Spanish community (or at least those of them that wants to participate). @qdp-odoo what do you think?

@qdp-odoo

This comment has been minimized.

Show comment
Hide comment
@qdp-odoo

qdp-odoo Sep 18, 2018

Contributor

@pedrobaeza @oco-odoo Indeed we've been a little too fast here, and it's my fault (I told Olivier to merge it as it was looking okayish)... But deal. Next time we'll make a PR and wait for the Spanish community opinion.

For this patch, can you review it or do you think we should revert it?

Contributor

qdp-odoo replied Sep 18, 2018

@pedrobaeza @oco-odoo Indeed we've been a little too fast here, and it's my fault (I told Olivier to merge it as it was looking okayish)... But deal. Next time we'll make a PR and wait for the Spanish community opinion.

For this patch, can you review it or do you think we should revert it?

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Sep 18, 2018

Contributor

Let me check if there's any problem, and if not, we can keep it for not messing the commit history. I'll propose a PR if I see any problem. Thanks for the understanding on this.

Contributor

pedrobaeza replied Sep 18, 2018

Let me check if there's any problem, and if not, we can keep it for not messing the commit history. I'll propose a PR if I see any problem. Thanks for the understanding on this.

Please sign in to comment.