[FIX] l10n_es: apply correct type to each account.
@oco-odoo from where are these changes based?
@pedrobaeza We got feedback about them from one of our customers ;)
Yeah, but this kind of thing must be checked at least with me as leader of the OCA Spanish Localization PSC, now that we have converged both l10n_es (OCA and Odoo) in one. And not only that, that customer (which I suspect who is) haven't made any contribution, but they are relied as a trusted source for this information?
This even had a PR for being discussed, or am I mistaken?
I haven't dug enough yet, but changing reconcile flag of some accounts is not a good idea when updating chart of accounts (via account_chart_update module) when you already have journal items, and not only that, it impacts on the statement workflow, presenting accounts that can be inconvenient to be shown (and this for all users - on new chart of accounts or existing ones -).
I think this should be planned in other way and discussed with whole Spanish community (or at least those of them that wants to participate). @qdp-odoo what do you think?
@pedrobaeza @oco-odoo Indeed we've been a little too fast here, and it's my fault (I told Olivier to merge it as it was looking okayish)... But deal. Next time we'll make a PR and wait for the Spanish community opinion.
For this patch, can you review it or do you think we should revert it?
Let me check if there's any problem, and if not, we can keep it for not messing the commit history. I'll propose a PR if I see any problem. Thanks for the understanding on this.