Skip to content
Permalink
Browse files

[FIX] models.py: Don't commit after fetching a translation

Purpose
=======

When trying the translate a sql_contraint message after an integrity error
we use the current cursor in a 'with', just to make a SELECT query.

That way, the cursor is commited at the end of the with statement, trying
to commit the inconsitent state of the cursor that was the reason of the
integrity error.

Just close the cursor, as we only fetch translations from the database.
  • Loading branch information...
tivisse committed Sep 5, 2019
1 parent 33df0f5 commit 80b46d738ec79c2775df745dad1e22401b491693
Showing with 2 additions and 1 deletion.
  1. +2 −1 odoo/service/model.py
@@ -1,5 +1,6 @@
# -*- coding: utf-8 -*-

from contextlib import closing
from functools import wraps
import logging
from psycopg2 import IntegrityError, OperationalError, errorcodes
@@ -73,7 +74,7 @@ def tr(src, ttype):

# We open a *new* cursor here, one reason is that failed SQL
# queries (as in IntegrityError) will invalidate the current one.
with odoo.sql_db.db_connect(dbname).cursor() as cr:
with closing(odoo.sql_db.db_connect(dbname).cursor()) as cr:
if ttype == 'sql_constraint':
res = translate_sql_constraint(cr, key=key, lang=lang)
else:

0 comments on commit 80b46d7

Please sign in to comment.
You can’t perform that action at this time.