Skip to content
Permalink
Browse files

[FIX] portal: odd sidebar on IE11

Open a quotation from the portal using IE11. The sidebar is rendered as
it did not have any width.

The problem is due to the rule `flex-grow: 0 !important` applied by the
selector `.flex-lg-grow-0` on the sidebar. On Chrome/Firefox the dom
element takes the width of his children as minimal width, the
`flex-grow: 0` does not shrink the element bellow that minimal width.
IE11 does not set a minimal width based on the child elements of the
node, the width is equal to 0 and the `flex-grow: 0` forbid it from
growing.

The fix is to apply an IE11 bootstrap specific fix that expands the
`.flew-lg-grow-0` rules to force a minimal width. The width = 252 is
the width of the children elements as computed by Firefox.

opw-1944188
opw-1935087
  • Loading branch information...
Julien00859 committed Apr 8, 2019
1 parent 4da8277 commit 88f07171d3c1bc7b96020228f0e92d3fc750a4d1
Showing with 6 additions and 0 deletions.
  1. +6 −0 addons/portal/static/src/scss/portal.scss
@@ -182,6 +182,12 @@ hr {
background-color: inherit;
}

// IE 11 hack
// http://browserhacks.com/#hack-d19e53a0fdfba5ec0f283ae86175a3af
*::-ms-backdrop, :root, .o_portal_sale_sidebar .flex-lg-grow-0 {
min-width: 252px;
}

// Replaces old BS3 page-header class
%o-page-header {
margin-bottom: $headings-margin-bottom * 2;

0 comments on commit 88f0717

Please sign in to comment.
You can’t perform that action at this time.