Skip to content
Permalink
Browse files

[FIX] payment_ogone: correct list of params for SHA-OUT computation

Some parameters were missing, leading to incorrect SHA-OUT calculation
on Odoo's side. Some were removed as well.

opw-2121544

closes #41067

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
  • Loading branch information
dbo-odoo committed Nov 28, 2019
1 parent 52d6f0e commit af184e7c4fb89752263a53794e4807f601587ecd
Showing with 13 additions and 7 deletions.
  1. +13 −7 addons/payment_ogone/models/payment.py
@@ -79,7 +79,7 @@ def filter_key(key):
return True
else:
# SHA-OUT keys
# source https://viveum.v-psp.com/Ncol/Viveum_e-Com-BAS_EN.pdf
# source https://payment-services.ingenico.com/int/en/ogone/support/guides/integration guides/e-commerce/transaction-feedback
keys = [
'AAVADDRESS',
'AAVCHECK',
@@ -96,8 +96,11 @@ def filter_key(key):
'CARDNO',
'CCCTY',
'CN',
'COLLECTOR_BIC',
'COLLECTOR_IBAN',
'COMPLUS',
'CREATION_STATUS',
'CREDITDEBIT',
'CURRENCY',
'CVCCHECK',
'DCC_COMMPERCENTAGE',
@@ -109,35 +112,38 @@ def filter_key(key):
'DCC_INDICATOR',
'DCC_MARGINPERCENTAGE',
'DCC_VALIDHOURS',
'DEVICEID',
'DIGESTCARDNO',
'ECI',
'ED',
'EMAIL',
'ENCCARDNO',
'FXAMOUNT',
'FXCURRENCY',
'IBAN',
'IP',
'IPCTY',
'MANDATEID',
'MOBILEMODE',
'NBREMAILUSAGE',
'NBRIPUSAGE',
'NBRIPUSAGE_ALLTX',
'NBRUSAGE',
'NCERROR',
'NCERRORCARDNO',
'NCERRORCN',
'NCERRORCVC',
'NCERRORED',
'ORDERID',
'PAYID',
'PAYIDSUB',
'PAYMENT_REFERENCE',
'PM',
'SCO_CATEGORY',
'SCORING',
'SEQUENCETYPE',
'SIGNDATE',
'STATUS',
'SUBBRAND',
'SUBSCRIPTION_ID',
'TICKET',
'TRXDATE',
'VC'
'VC',
]
return key.upper() in keys

0 comments on commit af184e7

Please sign in to comment.
You can’t perform that action at this time.