Skip to content

Commit

Permalink
[FIX] web_editor: snippet options were not working if not pure text
Browse files Browse the repository at this point in the history
Some snippet options uses an image or icon as description instead of
text (like the gradient option in some themes). Those were not working
anymore as the user click was considered on the image/icon instead of
the option itself.
  • Loading branch information
qsm-odoo committed Oct 15, 2018
1 parent e774b2c commit ba414ee
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions addons/web_editor/static/src/js/editor/snippets.options.js
Expand Up @@ -303,8 +303,8 @@ var SnippetOption = Widget.extend({
* @param {Event} ev
*/
_onLinkEnter: function (ev) {
var $opt = $(ev.target);
if (!$opt.hasClass('dropdown-item')) {
var $opt = $(ev.target).closest('.dropdown-item');
if (!$opt.length) {
return;
}

Expand All @@ -331,8 +331,8 @@ var SnippetOption = Widget.extend({
* @param {Event} ev
*/
_onLinkClick: function (ev) {
var $opt = $(ev.target);
if (!$opt.hasClass('dropdown-item') || !$opt.is(':hasData')) {
var $opt = $(ev.target).closest('.dropdown-item');
if (!$opt.length || !$opt.is(':hasData')) {
return;
}

Expand Down

0 comments on commit ba414ee

Please sign in to comment.