Skip to content
Browse files

[FIX] base_setup: do not create deleted parameter

The base_setup.show_effect parameter is created at module installation (with
an external id) and is removed (and its external id) when the option
"Show Effect" is unchecked from the general setting.

When this option is checked again, the ir.config.parameter entry is recreated
but without an external id (as it is user-provided data, not from a data file).

When the module base_setup is updated, the record base_setup.show_effect is
recreated and the unicity constraint on ir.config.parameter is raised.

Set the record as forcecreate="False" to avoid recreating it when the module
is updated.
Anyway, if somebody uncheck the option, it is not expected to get it back when
the module is upgraded.

Fixes #32806
  • Loading branch information...
mart-e committed Apr 18, 2019
1 parent d637fe4 commit cf9c9248ea67b3aad98b1b7806d36938bec39f1d
Showing with 1 addition and 1 deletion.
  1. +1 −1 addons/base_setup/data/base_setup_data.xml
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<data noupdate="1">
<record model="ir.config_parameter" id="show_effect">
<record model="ir.config_parameter" id="show_effect" forcecreate="False">
<field name="key">base_setup.show_effect</field>
<field name="value">True</field>

0 comments on commit cf9c924

Please sign in to comment.
You can’t perform that action at this time.