Permalink
Browse files

[REF] tests: replace phantomjs by Chrome headless

As the phantomjs project was suspended[1], there was a need to change the js test
engine. Moreover, the engine was rather old and leading to non
deterministic crashes.

Chrome headless was choosen for simplicity and the long term vision of
the devtools protocol [2].

The 'phantom_js' method still exists but will be deprecated in
favor of 'browser_js' with the same parameters.

In order to communicate with the browser, the python websocket-client package
is needed.

[1] ariya/phantomjs#15344
[2] https://chromedevtools.github.io/devtools-protocol/

#closes 25991
  • Loading branch information...
antonylesuisse authored and d-fence committed Aug 16, 2018
1 parent 726a356 commit de84ad9c1f4853cb8a748ee1d0c880081dae9fe2
Showing with 346 additions and 285 deletions.
  1. +346 −140 odoo/tests/common.py
  2. +0 −145 odoo/tests/phantomtest.js
Oops, something went wrong.

1 comment on commit de84ad9

@blaggacao

This comment has been minimized.

Show comment
Hide comment
@blaggacao

blaggacao Aug 19, 2018

Contributor

google-chrome is not a native command on my linux distribution, what is the idea here? symlink or is it known not to work with chromium?

Contributor

blaggacao commented on de84ad9 Aug 19, 2018

google-chrome is not a native command on my linux distribution, what is the idea here? symlink or is it known not to work with chromium?

Please sign in to comment.