Skip to content
Branch: 12.0
Commits on Apr 4, 2019
  1. [FIX] base, base_address_extended: optimisation of partners import

    robodoo committed Apr 4, 2019
    If bulk-importing clients with a parent_id set, there's a ton of extra /
    post-processing work which is not batched and "de-optimises" the
    batching added to import.
    High-level comparison of performing a "Test Import" on a synthetic test
    file of 10000 partners (all with a parent_id set to a pre-existing
    record) went from ~30mn to ~8mn on my machine.
    Fixes #31549
    closes #31876
    Signed-off-by: Xavier Morel (xmo) <>
Commits on Apr 2, 2019
  1. [IMP] hw_*: IoT refactoring - With longpolling

    robodoo committed Apr 2, 2019
    Improve the implementation of IoT.
    Allow both-direction communication between iot box and devices.
    task: 1906910
    closes #30440
    Signed-off-by: Christophe Simonis <>
Commits on Feb 5, 2019
  1. [FIX] hr_holidays: fasten creation of leaves by company

    robodoo committed Feb 5, 2019
    When creating a leave, we usually check/create activities for the
    concerned users, this is fine when creating one leave.
    However it starts to become a problem when trying to create leaves in
    batch using the by company or by department holiday_type as the number
    of leaves created in batch can become quite big.
    Now when we create leaves in batch, we do not check for the activities,
    which will fasten a lot the creation.
    Another problem is that when someone defined a leave on the very day you
    want to create such a request, then it will crash, this can lead to
    waste of time and resources.
    Now we raise an error before trying to create the leaves in case of
    NB: Tested with +- 320 records, took 20 seconds instead of more than 10 minutes.
    Task: 1934383
    I confirm I have signed the CLA and read the PR guidelines at
    closes #30625
Commits on Jan 28, 2019
  1. [FIX] base order pdfs when attachment_use option se…

    robodoo committed Jan 28, 2019
    Description of the issue/feature this PR addresses:
    Order of merged pdf reports when attachment_use = True
    Current behaviour before PR:
    When in a report the "Reload from Attachment" option was selected
    (attachment_use = True), and multiple pdfs were printed, the singular pdfs
    were stored in a dictionary and appended to a list and thus merged in a random order.
    Desired behaviour after PR is merged:
    By mapping the pdf with their source record, and sorting the list with the table _order of
    the source records of the pdfs, we seek to have an ordered output pdf.
    opw 1915685
    I confirm I have signed the CLA and read the PR guidelines at
    closes #30402
Commits on Jan 24, 2019
  1. [IMP] l10n_be_hr_payroll_fleet, fleet: Adapt CO2 Tax up to 2019

    robodoo committed Jan 24, 2019
    - Adapt the formula used in the code with the current legal value.
    - Add the LPG fuel type in standard fleet module.
    - Adapt the atn formula in the code with the current legal value.
    Description of the issue/feature this PR addresses:
    Current behavior before PR:
    Desired behavior after PR is merged:
    I confirm I have signed the CLA and read the PR guidelines at
    closes #30484
Commits on Jan 15, 2019
  1. [MERGE/FIX] web_tour,*: remove step delay in tests

    robodoo committed Jan 15, 2019
    For historical reasons, the tour manager executed each step of tour
    in a setTimeout (10ms). When a step could be executed (i.e. when
    its trigger selector has a match in the DOM), the element matching
    its trigger was saved as a jQuery element (the $anchor), and in the
    setTimeout, the action (e.g. click) was performed on that element.
    However, it could happen that, after the delay, the $anchor was no
    longer in the DOM, either because
     1) the tip selector had no match anymore, meaning that the element
        had been removed from the DOM meanwhile
     2) the tip selector still had a match in the DOM, but that element
        had been rerendered meanwhile
    Case 2) occured sometimes when the main_flow_tour was executed in
    community, when trying to open a Manufacturing Order after having
    reloaded the Manufacturing Order list view (because the row of the
    order to open that was saved as $anchor was the one of the list
    before the reload, and that list was re-rendered during the delay).
    This rev. removes the default delay of 10ms, but the feature is
    kept such that one can still manually run a tour slowly (e.g. to
    debug or to make a demo). It also adapts some tours that didn't pass
    anymore without the delay, and it fixes a bug in the kanban view that
    has been spotted thanks to the delay removal.
    closes #30106
Commits on Jan 4, 2019
  1. [IMP] l10n_be_hr_payroll: Update salary rules up to 2019

    robodoo committed Jan 4, 2019
    Update withholding taxes and child allowances for the new fiscal year.
    closes #29931
Commits on Dec 4, 2018
  1. [FIX] survey: fix various issues in customer view about datetimepicker

    robodoo committed Dec 4, 2018
    Survey has troubles displaying correctly the datetime picker widget
    especially when more than one has to be instanciated. This merge fixes
    several issues related to the datetime widget when displaying the survey
    in customer (front-end like) view.
    See sub-commits for more details about each change.
    This merge is related to task ID 1912194.
    closes #28966
Commits on Nov 29, 2018
  1. [MERGE] account: Improve partner suggestion in the reconciliation widget

    robodoo committed Nov 29, 2018
    See commits for more details.
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28758
  2. [MERGE][FIX] portal, *: stop breaking behaviors on dblclick

    robodoo committed Nov 29, 2018
    * web, website, payment, website_sale
    See sub-commits for details.
    closes #29001
Commits on Nov 28, 2018
  1. [IMP] hr_attendance: faster loading of employees kanban view

    robodoo committed Nov 28, 2018
    **Description of the issue/feature this PR addresses:**
    Addon hr_attendance adds a check_in/check_out status icon in every card of the employee kanban view. The status is figured out using computed field ``attendance_state``, itself relying on a computed Many2one field, ``last_attendance_id``.
    The current way to compute the latter field seems to fetch all attendances before getting the most recent one. For each employee. Which causes the employee kanban view to load very slowly (~30 sec in 90-employee Camptocamp's instance).
    This PR suggests to load only the last attendance entry.
    Co-authored with @guewen
    **Current behavior before PR:**
    Employee kanban view loads very slowly.
    **Desired behavior after PR is merged:**
    Employee kanban view loads reasonably fast.
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28953
  2. [MERGE][FIX] im_livechat: correct configuration path and improved sen…

    robodoo committed Nov 28, 2018
    In the form view of a livechat, the instructions to configure with Odoo
    website CMS was still referring to "Website Admin", instead of
    In addition to fixing this error, the sentence has been slightly improved,
    as we have to regenerate the term anyway.
    closes #29115
  3. [FIX] website_forum: show correct title on hover over accept answer

    robodoo committed Nov 28, 2018
    Description of the issue/feature this PR addresses: Fix wrong title on hover
    Current behavior before PR: When hovering over the icon to accept an answer on the forum it will show the text "Send answer":
    Desired behavior after PR is merged:
    The text says "Accept answer" as you're accepting an answer, not sending one.
    I confirm I have signed the CLA and read the PR guidelines at
    closes #29101
Commits on Nov 22, 2018
  1. [FIX] web: search input date in another timezone

    robodoo committed Nov 22, 2018
    Put the browser in timezone Sao Paulo (Or like West of UTC)
    Trigger the autocomplete (and the subsequent search) on a date field
    by writing a date (in the locale format) in the search view
    Before this commit, the domain sent to the server contained the date as the day
    **before** the one asked for in the input
    This is because, the string input is parsed and gives:
    input = 12/02/2018
    When creating the moment object:
    > since there is no explicit time, moment will interpret it as 12am (midnight)
    > We force moment to consider the string as being UTC (function: moment.utc())
    > the moment contains, as output the time ** 2018-02-12T00:00:00 UTC **
    When getting the facet value for making the domain
    > we call toDate on the moment object, which, according to the browser is UTC and will
    be converted to the locale timezone before formatting
    > And the domain will use the date 2018-02-11T22:00:00 Brazil/SaoPaulo
    which gives the day before the one we asked for
    After this commit, this issue doesn't arise, because we use the string representation of
    the moment object in search_inputs (i.e 2018-02-12T00:00:00 UTC), to create a new one
    *BUT* we create it with a date format that excludes the time from being interpreted.
    Also, the resulting moment object in this case is not flagged as UTC anymore
    OPW 1903224
    closes #28542
Commits on Nov 16, 2018
  1. [MERGE][FIX] mail: several fixes in discuss, chat window, chatter

    robodoo committed Nov 16, 2018
    This merge fixes a crash in discuss, in addition to re-introduce some _quality of life_
    features that have been mistakenly removed from the chatter and from chat windows:
    ### 1. No crash when searching messages
    This was caused by the addition of moderated channels. In short, fetching twice
    the same message was performing a re-render of the thread due to a mis-consideration
    of a moderation status change. When the fetch reaches the fetch limit, the re-render is
    considered as a "load more" fetch, which only works when there is at least one message
    registered for the current search.
    This is fixed by re-render when there is a change of moderation status only.
    Task-ID 1910180
    ### 2. Easily mention followers and employees in chatter
    When mentioning a user from the chatter in a document, it was always
    fetching all partners in a arbitrary order. As a result, it was hard to mention
    followers and employees.
    This is fixed by re-introducing the previous behaviour on mentions, which
    groups them by followers, then employees, then all partners.
    Task-ID 1910111
    ### 3. Show message document link in chat window
    When a message is linked to a document, it usually shows a
    link next to the message. This still works in the Discuss app,
    but not in chat windows.
    This erroneous regression was caused by a refactoring.
    This is fixed by re-introduced document links on messages in chat
    Task-ID 1910119
    closes #28744
Commits on Nov 15, 2018
  1. [FIX] stock: readonly on show details operations

    robodoo committed Nov 15, 2018
    commit c6b0d36 introduced a wrong
    domain. The readonly should be added if the show_operations is false
    OR state is done AND is_locked is true.
    close #28595
    Description of the issue/feature this PR addresses:
    Current behavior before PR:
    Desired behavior after PR is merged:
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28603
  2. [FIX] web: fix performance issue with read_progress_bar

    robodoo committed Nov 15, 2018
    This PR fixes some miscellaneous issues:
    - performance issue in read_progress_bar
    - performance issue in activity view
    - crash in ungrouped kanban view with progress bar
    closes #28715
Commits on Nov 14, 2018
  1. [MERGE][FIX] mail: preview not linked to any document

    robodoo committed Nov 14, 2018
    This fixes two issues relating to previews in the systray messaging menu
    that are not linked to any document:
    1. Clicking on such preview now redirects to Inbox
    There was a traceback, because it was attempting to open a document.
    2. Marking a read one of those previews now only marks this preview
    It was marking all previews not linked to a document as read.
    Task-ID 1891350
    Task-ID 1907159
    closes #28462
Commits on Nov 12, 2018
  1. [FIX] event, mail: company in mail footer

    robodoo committed Nov 12, 2018
    closes #28416
Commits on Nov 6, 2018
  1. [FIX] web: accept field name as a groupby descriptor

    robodoo committed Nov 6, 2018
    In some cases, and for historical reasons, the groupby property can be
    expressed as a string (for example, 'stage_id') instead of a list of
    strings (for example, ['stage_id']).
    However, the support was not complete. A crash could happen in some
    cases. For example, if there is a group_by: 'stage_id' property in the
    context of an action, it works in list view, but adding that view to the
    dashboard would result in a crash, without this commit.
    Description of the issue/feature this PR addresses:
    Current behavior before PR:
    Desired behavior after PR is merged:
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28408
Commits on Nov 5, 2018
  1. 12.0 Various snailmail Improvements

    robodoo committed Nov 5, 2018
    The pricing on snailmail has changed and we now charge stamps for each letter.
    Added a new error to help the user more specifically
    Avoid spamming the user's mailbox with the next  activities when a letter can not be sent.
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28290
Commits on Oct 29, 2018
  1. [FIX] procurement_jit, stock: unreservation

    robodoo committed Oct 29, 2018
    We fix two problems with the 'unreserve' function on picking and sale order,
    When a sale order is edited, we perform 'do_unreserve' on picking, it is not necessary and make us loose the done quantity put on the picking so we remove it.
    When we unreserve a picking having a package level added through a put in pack or automatically added on reservation, the package level is set back to draft instead of being removed
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28188
Commits on Oct 26, 2018
  1. [MERGE][FIX] base_vat_autocomplete: add missing attrs

    robodoo committed Oct 26, 2018
    VAT number should be readonly when parent_id is set
    This is already what is done in base.view_partner_form and
    closes #28190
  2. [FIX] account: fix onboarding issues

    robodoo committed Oct 26, 2018
    * fix in the accounting config bar ('add a bank' and 'fiscal year' steps)
    * better display names and icons for vendor bills uploaded manually (moved some code that was previsouly only done in document_account for vendor bills created through the DMS)
    closes #27882
Commits on Oct 25, 2018
  1. [FIX] different IAP related problems

    robodoo committed Oct 25, 2018
    widget of crm_reveal did not call the correct service name, becoming useless
    Allow saas clients to access their iap accounts portal
    I confirm I have signed the CLA and read the PR guidelines at
    closes #28163
Commits on Oct 23, 2018
  1. [FIX] auth_ldap: missing model description

    robodoo committed Oct 23, 2018
    Missing model description produces a warning when the module is installed
    closes #28047
  2. [MERGE][FIX] test(_mass)_mail: simulate email sending in performance …

    robodoo committed Oct 23, 2018
    Commit 356a421 introduced a hook to avoid sending emails while
    installing application data. However we have to carefully re-activate email
    sending in tests that depend on them especially performance tests.
    Performance counters are updated to match current runbot state for both
    community and enterprise.
    Mass mailing performance class is made a direc child of TransactionCase
    to ease manipulation and be able to use patch.
    This merge is related to task ID 1902307 and is mainly a fix and better use
    of odoo-dev@356a421.
    closes #28027
Commits on Oct 22, 2018
  1. [IMP] snailmail: Change formatting of address in snailmail

    robodoo committed Oct 22, 2018
    The previous format displayed the fields 'street' and 'street2' on two different line, making the address too big for the address area allowed by Pingen.
    I confirm I have signed the CLA and read the PR guidelines at
    closes #27841
Commits on Oct 19, 2018
  1. [MERGE] website, *: fix some snippet options

    robodoo committed Oct 19, 2018
    * web_editor
    See sub-commits for details.
    closes #27966
  2. [MERGE] website, *: fix some snippet options

    robodoo committed Oct 19, 2018
    * web_editor
    See sub-commits for details.
    closes #27969
  3. [MERGE][FIX] livechat, *: open livechat from URL

    robodoo committed Oct 19, 2018
    *: mail, web
    This fixes the following issues:
    ### 1. Livechat menu was not visible when accessing from the customer URL
    The customer URL is obtainable by following those steps:
    - Access `/web`
    - Click on Live Chat app
    - Open a Live Chat Channel
    - Click on "Widget" sheet
    - Access livechat from (2nd) "Copy Text" button
    This is due to missing JS modules in the external lib, such as the root widget.
    ### 2. The position of the buttons "Copy Text" is modified on pressing 'ALT'
    This is caused by the keyboard navigation overlay that changes the CSS
    position of the parent of the overlay element. It sets the position to
    `relative`, so that the overlay exactly covers the element. However, if the
    element had a position `absolute`, changing it to `relative` may re-position it
    somewhere else on the page.
    In fact, it is not necessary to set the CSS position to `relative` in this case,
    because the overlay has CSS position `absolute`: an element with `absolute`
    will match the size of the parent if the parent is also `absolute`.
    Task-ID 1885445
    closes #27578
Commits on Oct 18, 2018
  1. [MERGE][REF] (test_)mass_mailing: move/improve tests and fix link sho…

    robodoo committed Oct 18, 2018
    Purpose of this merge is to move some mass mailing tests into test_mass_mailing
    module. Some tests were duplicated when merging new mass mailing tests at
    0c37eb2 . This merge moves some tests to the specific test module for mass mailing.
    Performance tests are also added to have some counters for future mass mailing
    A tool method to create new test users is also added in order to reduce
    duplicated code present in a lot of tests. It allows to quickly create tests
    users given a login and access rights groups.
    See sub commits for more details.
    This merge is linked to task ID 1889703
    closes #27526
  2. [FIX] base, doc: RTLCSS on Windows

    robodoo committed Oct 18, 2018
    RTLCSS is not working on Windows for several reasons:
    - the executable is called `rtlcss.cmd`
    - rtlcss is not available in the System Path; it is only available in
      the User Path
    closes #27896
Commits on Oct 17, 2018
  1. [MERGE] mail: fix some moderation issues

    robodoo committed Oct 17, 2018
    This fixes two issues:
    1. non-working moderation in chat window
    Moderation on chat windows were not working: it was displaying
    the moderation checkbox and decisions next to pending moderation
    messages, but none of them were working in a chat window.
    Those features should only work with the Discuss app.
    2. cannot see self-authored, pending moderation messages
    When a non-moderator user was posting a message in a moderated
    channel and refreshes the page, he would no longer see his messages
    that are pending moderation. Those messages should stay visible for
    the author until a moderator makes a decision, e.g. reject the message.
    Task-ID 1887963
    closes #27640
Commits on Oct 12, 2018
  1. [FIX] web: do not create partner from calendar's sidebar

    robodoo committed Oct 12, 2018
    Fixes #27666
    closes #27720
You can’t perform that action at this time.