Skip to content
Permalink
Branch: 12.0
Commits on Jun 13, 2019
  1. [FIX] account: Duplicating posted journal entries

    simongoffin committed Jun 13, 2019
    Steps to reproduce:
    
    - Go into accounting> journal entries and
    - Choose a posted entry
    - Press the duplicate button
    
    Bug:
    No button Edit, Save or Discard for the duplicated record.
    
    Fine tuning of this commit: d79007c
    
    opw:2009050
    
    closes #34096
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Jun 6, 2019
  1. [FIX] hr_holidays: Not able to fill holiday request

    simongoffin committed Jun 5, 2019
    Steps to reproduce the bug:
    - Log as admin user in company C
    - Go to Leaves module and click on Managers > Allocations
    - Create a leave.allocation with type = Compensatory Days, duration = 7 days
    mode = By Company and Company = C
    - Approve the allocation
    - Create a leave request LR for all the company C and approve it
    - Log as demo user (only user access right for Leaves)
    - Go to Leaves > My Leaves and click on "Leaves requests"
    
    Bug:
    
    A traceback was raised
    
    opw:2005813
    
    closes #33899
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Jun 4, 2019
  1. [FIX] point_of_sale: Initial balance of a new statement in the POS

    simongoffin committed Jun 4, 2019
    Steps to reproduce the bug:
    - Create a new Bank Account A available in the POS
    - Set A as a payment method in the pos.config
    - Create a new session and sell a product P for 100€
    - Make the payment with A
    - Close the session and validate the entries
    - Check that a new statement in A has been created with a starting
    balance = 0€ and an ending balance = 100€
    - Create a new session and close the session
    
    Bug:
    
    A new statement for A had been created with a starting balance = 0€
    instead of 100€ (the ending balance of the previous session)
    
    opw:1981984
    
    closes #33868
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  2. [FIX]payment_paypal: wrong fees computation

    simongoffin committed Jun 3, 2019
    Steps to reproduce the bug:
    - Create a product P with price=100€
    - Configure payment aquier Paypal with fees_int_fixed = 1€ and fees_int_var = 1%
    - Set Paypal to be available in the website
    - Go to the web shop and add P in the cart
    - Choose to pay with Paypal
    
    Bug:
    
    The amout to pay was 102.02€ instead of 102.01€
    
    Before the fix, the fees was computed as followed:
    
    fees = (percentage / 100.0 * amount + fixed) / (1 - percentage / 100.0)
    Where fees_dom_fixed = fixed and fees_int_var = percentage
    
    With this computation, the percentage was applied twice.
    If for example, we had fixed = 0 then
    
    fees = (percentage / 100.0 * amount) / (1 - percentage / 100.0)
    
    In this case, it's easy to see that the percentage is applied twice.
    
    opw:1981784
    
    closes #33830
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 22, 2019
  1. [FIX] sale: T&C issue when changing partner

    simongoffin committed May 14, 2019
    Steps to reproduce:
    1. Create an invoice with a customer and enter some text in Terms and Conditions (field: comment).
    2. Save the invoice.
    3. Edit the invoice and change the customer.
    
    Bug:
    The text in Terms and Conditions was empty.
    
    Same behavior as on the SO, if the company doesn't change the T&C should be kept.
    
    Fine tuning of this commit: 9bf1f97
    Closes #32309
    
    opw:1830838
    
    closes #33383
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 17, 2019
  1. [FIX] portal, website_mail: Wrong dependance

    simongoffin committed May 15, 2019
    The field website_published is not ensured when module portal
    is installed because the module portal doesn't depend on module
    website_mail.
    
    PS:The module website_mail depends on the module portal because
    website_mail depends on website and website depends on portal.
    
    opw:1997478
    
    closes #33452
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 16, 2019
  1. [FIX] web: Invalid Date warning

    simongoffin committed May 16, 2019
    Fine tuning of 5ef86ef
    
    Steps to reproduce:
    Set a custom language settings for date by switching the %m and %d.
    Create a sales order
    
    Current behavior:
    Invalid date error boxes was raised two times
    
    fixes #33408
    
    opw:1998971
    
    closes #33415
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 15, 2019
  1. [FIX] web: Error on invalid date format on date field input

    simongoffin committed May 14, 2019
    Steps to reproduce the bug:
    
    - Go to any field Date
    - Enter wrong date
    
    Bug:
    A traceback was raised.
    
    Now a warning is raised and the wrong value is removed.
    
    opw:1974747
    
    closes #33362
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 13, 2019
  1. [FIX] mrp_byproduct: Impossible to process a work order

    simongoffin committed May 9, 2019
    Steps to reproduce the bug:
    
    - Create two storable products A and B
    - Create a BOM for A with B as component and A as by product
    - Set this BOM as "To manufacture"
    - Create a MO for A and try to process it
    
    Bug:
    
    Ensure one error was raised by function check_finished_move_lots defined in module mrp
    because the variable produce_move must be one record.
    
    Now, it's not possible to create a MO for A if A has a BOM with A as by product.
    
    opw:1974863
    
    closes #33280
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 6, 2019
  1. [FIX] sale_timesheet: Wrong remaining value in Project overview

    simongoffin committed May 6, 2019
    Steps to reproduce the bug:
    - Create a project called "R&D"
    - Create two service products P1 and P2 with 'Timesheets on tasks' and
    'Create a task in an existing project' for project 'R&D'
    - Create a SO1 with 5 P1 and SO2 with 10 P2 and confirm SO1 and SO2
    - Deliver 1 hour for P1 and 2 hours for P2 (with timesheets)
    - Click on "Project Overview" button
    
    Bug:
    
    The remaining hours for SO1 was 12 hours instead of 4 hours and the remaining hours
    for SO2 was 12 hours instead of 8 hours
    
    opw:1981903
    
    closes #33183
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on May 2, 2019
  1. [FIX] portal: Hide messages when unpublished for portal

    simongoffin committed Apr 30, 2019
    Steps to reproduce the bug:
    - Create a SO and go to my/account
    - Share the SO with a portal user P
    - Go to on the website
    - Write a message in the chatter and unpublish it
    - Log as P and go to the SO
    
    Bug:
    
    The unpublished message was displayed.
    
    Same logic as: d79678f
    
    opw:1969524
    
    closes #33053
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 30, 2019
  1. [FIX] l10n_ch: Error when saving a email template

    simongoffin committed Apr 30, 2019
    Steps to reproduce the bug:
    - Configured bank account for CHF with all the ISR related informations
    - Click on "Send & Print" on a customer invoice with that bank account
    - Save the email template
    
    Bug:
    
    An error was raised because the key 'attachments' didn't exist in the variable
    rslt.
    
    opw:1970005
    
    closes #33042
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  2. [FIX] sale_timesheet: Project(s) overview wrong with downpayment

    simongoffin committed Apr 25, 2019
    Steps to reproduce the bug:
    - Install Timesheet, Sales, Accounting
    - Create a product P that creates a project when validated on a SO
    - Create a SO with P and validate it
    - Create an invoice with a downpayment of 10% and validate it
    - On the SO, click on "Project(s) overview" smart button
    
    Bug:
    
    The invoiced amount  on the overview was not updated with the downpayment invoiced.
    When the SO was completely invoiced, the amount of the downpayment was counted in
    "Other cost" (because an analityc line is created for the downpayment SO line)
    
    opw:1969143
    
    closes #32962
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 23, 2019
  1. [FIX] stock: Error when re-installing manufacturing application

    simongoffin committed Apr 23, 2019
    Steps to reproduce the bug:
    - Install MRP
    - Uninstall MRP
    - Install MRP
    
    Bug:
    An error was raised by sql constraint 'barcode_company_uniq' which ensures that
    a barcode for a location is unique per company.
    But when uninstalling MRP, some locations such as pbm_loc_id or sam_loc_id are set to
    active = False and when re-installing MRP, the function _create_missing_locations tried
    to re-create these locations and the sql constraint was raised.
    
    opw:1967534
    
    closes #32882
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 18, 2019
  1. [FIX] mrp: Duplicate finished_move_line_ids from by_product in a BOM

    simongoffin committed Apr 17, 2019
    Steps to reproduce the bug:
    
    - Create product A (type='product',tracking='lot')
    
    - Create product B (type='product',tracking='lot')
    
    - Create product Z(type='consu',tracking='none')
    
    - Create BoM for product Z with product A as component and product B
    as sub_product (i.e. By product) + create any routing (i.e. 1 operation).
    
    - Create an MO for product z, plan it, process the given work order,
    input the serial/lot for the components and byproducts...
    
    Bug:
    
    Two lines for product B were displayed in the finished_move_line_ids of the MO
    
    This bug occured in enterprise because the function _create_checks defined on model
    'mrp.workorder' creates the quality checks that create the finished_move_line_ids
    for the by_product tracked by lot or by serial number (in fuction _update_active_move_line
    defined on model 'mrp.workorder').
    
    So the finished_move_line_ids were created two times with the ones created in fuction record_production
    defined on model 'mrp.workorder' in community.
    
    Co-authored-by: amoyaux <arm@odoo.com>
    
    opw:1963163
    
    closes #32779
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 17, 2019
  1. [FIX] sale_mrp: No delivered_qty computed with partial delivery

    simongoffin committed Apr 16, 2019
    Steps to reproduce the bug:
    - Create a consumable or storable final product A with invoicing policy
    in "delivered quantity"
    - Create two storable products B and C
    - Create a BOM kit for A with 1 B and 1 C
    - Create a SO with 5 qty of A and confirm it
    - Deliver 3 B and 2 C and either on "No backorder" or "With backorder"
    
    Bug:
    
    The delivered_qty on the SO line is of course not automatically updated
    (as in this case, a right value is not computable) but the delivered_qty
    was not updatable  manually and then it was possible to invoice the SO.
    
    Co-authored-by: nim-odoo <nim@odoo.com>
    
    opw:1966170
    
    closes #32733
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  2. [FIX] sale: Keep fiscal position from SO

    simongoffin committed Apr 16, 2019
    Steps to reproduce the bug:
    - Create two fiscal postions fp1 and fp2
    - Create a customer C with fp1
    - Create a SO for C and set fp2
    - Create an invoice for the SO
    
    BUG:
    
    The fiscal position of the SO was set to False.
    Now the fiscal position of the SO is kept when creating an invoice
    from a SO.
    
    opw:1963910
    
    closes #32713
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 16, 2019
  1. [FIX] sale: _get_conversion_rate called with no date

    simongoffin committed Apr 16, 2019
    Steps to reproduce the bug:
    - Define two pricelists P1(€) the default one and P2($) with discount_policy = 'without_discount'
    - Activate P1 and P2 on the website
    - Go on the shop and select P2
    
    Bug:
    
    An error was raised from function _get_conversion_rate because the arguments date and company_id were not defined
    because the function _get_real_price_currency was called from _website_product_id_change with
    the model "self.env['sale.order.line'] and not with a recordset. So the fields self.company_id and self.order_id.date_order
    were not defined.
    
    opw:1969849
    
    closes #32726
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 15, 2019
  1. [FIX] sale_mrp, sale_stock: No delivered_qty computed with partial de…

    simongoffin committed Apr 10, 2019
    …livery
    
    Steps to reproduce the bug:
    - Create a consumable or storable final product A with invoicing policy
    in "delivered quantity"
    - Create two storable products B and C
    - Create a BOM kit for A with 1 B and 1 C
    - Create a SO with 5 qty of A and confirm it
    - Deliver 3 B and 2 C and either on "No backorder" or "With backorder"
    
    Bug:
    
    The delivered_qty on the SO line is of course not automatically updated
    (as in this case, a right value is not computable) but the delivered_qty
    was not updatable  manually and then it was possible to invoice the SO.
    
    Co-authored-by: nim-odoo <nim@odoo.com>
    
    DO NOT FORWARD-PORT
    
    opw:1966170
    
    closes #32583
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  2. [FIX] delivery: Delivery method zip using the customer not shipping a…

    simongoffin committed Apr 15, 2019
    …ddress
    
    The available_carriers must be computed according to the shipping address.
    
    opw:1967445
    
    closes #32693
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  3. [FIX] stock_account: Multicompany wrong cost in picking validation

    simongoffin committed Apr 11, 2019
    Steps to reproduce:
    - 2 Companies Parent A, and Child B
    - Create a Stockable Product FIFO/automated,
    - In A leave cost as 0, in B give cost of 10
    - Create an SO for product in company B
    - Logged into Parent A, validate the picking for Child B
    
    Behavior before the fix:
    An error was raised saying: Error cost of 0 (but the SO had been created in B, so the price had to be 10.)
    
    Behavior after the fix:
    Now the cost of the company B is taken.
    
    closes #32329
    
    opw:1966322
    
    closes #32615
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 10, 2019
  1. [FIX]sale_stock: Issue when clicking on "No backorder"

    simongoffin committed Apr 10, 2019
    Steps to reproduce the bug:
    - Create a SO with no salesperson
    - Add a SO line with 2 storable product
    - Confirm the SO and deliver only one product
    - Click on "No backorder"
    
    Bug:
    
    A error was raised because the function "_log_activity"(called by _log_less_quantities_than_expected) requires a responsible
    
    Partial Backport: e1f9499
    
    opw:1950968
    
    closes #32592
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 8, 2019
  1. [FIX] hr_timesheet: Timesheet user access right issue

    simongoffin committed Apr 4, 2019
    Steps to reproduce:
    - Create a clean Odoo 12E database and install Project, Timesheets, Accounting, Sales and Purchase applications
    - Create a new project (e.g SO 6) and a new task (e.g milestone 1)
    - Create a new user with access rights for Project = user and for Timesheet = user, and nothing else
    - Login under this user, enter timesheet app and try to add a timesheet line in grid or kanban view
    
    Bug:
    
    An access rights error was raised but when trying to add a timesheet line from the list view, no
    error was raised.
    
    opw:1962126
    
    closes #32427
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 4, 2019
  1. [FIX] account_set: Wrong recomputation of the depreciation lines

    simongoffin committed Apr 3, 2019
    When a asset is confirmed, it's not allowed to link it to an invoice.
    Side effect, it recomputed the depreciation lines of the confirmed asset.
    
    opw:1961468
    
    closes #32388
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 3, 2019
  1. [FIX] purchase_stock: Wrong journal entry created from vendor bill

    simongoffin committed Apr 2, 2019
    Steps to reproduce:
    
    - Create a storable product P with a vendor V and a purchase price = 100€
    - Set the category of the prodcut to automated and AVCO and set a price diff account on it
    - Create PO for V with 10 P with a price_unit = 110€
    - Confirm the PO and deliver 7 P with no backorder
    - Change the ordered quantity of P to 9 on PO (and the unit_price will be set to 100€)
    - Go on the delivery order and deliver 2 remainig P
    - Create the invoice and validate it
    
    Bug:
    
    The amount due on the invoice was 900.02€ instead of 900.00€
    
    PS: The debit and credit of an aml are computed with the price (defined in function
    _anglo_saxon_purchase_move_lines) with the function _convert_prepared_anglosaxon_line
    defined on model account.invoice. So rounding the price unit after the computation
    of the price allows to keep the same total as the one computed for the PO.
    
    opw:1951465
    
    closes #32345
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 2, 2019
  1. [FIX] web: Wrong comparison in invoice analyes

    simongoffin committed Apr 2, 2019
    Steps to reproduce the bug:
    Let's consider that we are in 2019
    
    - Create two customer invoices: I1 and I2
    - I1 with invoice date = 2 april 2019 and amount = 100€
    - I2 with invoice date = 2 april 2018 and amount = 1000€
    - Go to Reporting > Invoices
    - Click on widget "Time Ranges" and set "Based on" Invoice Date and "Range" This Year "Compare To" Previous Year
    
    Bug:
    
    The untaxed total for previous year was 1100€ instead of 1000€ because it counted previous year and this year.
    
    opw:1962027
    
    closes #32331
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Apr 1, 2019
  1. [FIX] purchase: Labels in purchase.order form view not displayed

    simongoffin committed Apr 1, 2019
    The labels Request for Quotation and Purchase Order were not displayed.
    
    opw:1958631
    
    closes #32281
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Mar 28, 2019
  1. [FIX] account_check_printing: Error when clearing the currency

    simongoffin committed Mar 28, 2019
    Steps to reproduce the bug:
    - Activate multi currencies on your user
    - Let's consider currency A and currency B and currency A is the one set on your company
    - Create a customer invoice I with currency B
    - Go on the tree view of customer invoices and select I
    - Click on "Action" and select "Generate an invoice"
    - On the wizard, clear the currency B
    
    Bug: A traceback was raised because the function amount_to_text requires a currency.
    
    opw:1958888
    
    closes #32202
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Mar 26, 2019
  1. [FIX] mrp: Printing a BOM with a variant

    simongoffin committed Mar 26, 2019
    Steps to reproduce the bug:
    - Create a BOM for product P
    - Generate variants for P: P1 and P2
    - Go to BOM of P and click on Structure & Cost
    - Change the current variant to P2
    - Click on "Print"
    
    Bug:
    
    A traceback was raised because the function _get_bom expects in arguments that
    product_id is an id and not a recordset.
    
    opw:1950401
    
    closes #32128
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
  2. [FIX] product: Issues with product configurator with single attribute…

    simongoffin committed Mar 25, 2019
    … values
    
    When creating several attribute lines for the same attribute, the function _update_product_template_attribute_values
    in model 'product.template.attribute.line' only kept the product.template.attribute.value records of the last
    created line. So it generated issues with the product configurator because no value was founded for certain attribute line
    in function _get_possible_combinations defined in model 'product.template'.
    
    Now it's forbidden to create several attribute lines for the same attribute.
    
    opw:1950786
    
    closes #32086
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Mar 21, 2019
  1. [FIX] stock_picking_barch: Picking Barcodes missing on batch pickings…

    simongoffin committed Mar 21, 2019
    … report
    
    The picking barcode must be displayed in the batch picking report like in 11.0
    
    opw:1958092
    
    closes #32004
    
    Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Commits on Dec 4, 2018
  1. [FIX] sale_stock, stock: Wrong dependency

    simongoffin committed Nov 29, 2018
    The field sale_id on model stock.picking is not defined in stock module.
    So the rule was wrong when sale_stock was uninstalled.
    
    opw:1912564
    
    closes #29145
Commits on Nov 28, 2018
  1. [FIX] sale: Wrong amount amount invoiced in sale.report

    simongoffin committed Nov 28, 2018
    Steps to reproduce the bug:
    
    Let's consider a product P with a unit price = 10
    
    - Create a SO for two lines of the same product P
    - Validate the SO and create the invoice
    - Refund the invoice and validate it
    - Go to Reporting > Sale report and select "Invoiced amount" as measures
    
    Bug= -20 was displayed for the invoiced amount.
    
    Technically, the two refund invoice lines of P were used two times in function
    _compute_invoice_amount because for each SO line we catched all the refund lines
    of the same product.
    
    opw:1906445
    
    closes #29095
Commits on Nov 19, 2018
  1. purchase_mrp: qty_received not updated on a PO

    simongoffin committed Nov 19, 2018
    Steps to reproduce the bug:
    
    - Let's consider a product P with a BOM in kit
    - Create a PO with P and confirm it
    - Cancel the shipment and the PO
    - Reset to draft the PO and confirm it
    - Valide the new shipment and receive P
    
    Bug:
    
    The qty_received was not updated
    
    opw:1904678
Commits on Nov 14, 2018
  1. [FIX] sale_stock: Decreasing ordered quantity on a SO

    simongoffin committed Nov 14, 2018
    Steps to reproduce the bug:
    
    - Set decimal precision to 7 for products.
    
    - Order 2.000000 of a product.
    
    - Deliver 2.6791200 of the product.
    
    - Go back to the Sales order and change the ordered quantity to 2.6791200.
    
    Bug:
    
    A UserError was raised: "You cannot decrease the ordered quantity below the delivered quantity."
    
    opw:1904580
    
    closes #28674
Older
You can’t perform that action at this time.