Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] stock: Add 'name_search' by barcode in stock.location #12043

Closed

Conversation

Projects
None yet
4 participants
@moylop260
Copy link
Contributor

commented May 13, 2016

  • Fix #3624
  • [REF] stock: Add 'name_search' by barcode in stock.location
  • [REF] stock: Add tests to name_search by barcode, name & non-existent
@moylop260

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2016

@odony @rco-odoo
What do you think about?

@moylop260 moylop260 force-pushed the vauxoo-dev:master-odoo-search-loc-barcode branch 5 times, most recently May 14, 2016

@moylop260 moylop260 force-pushed the vauxoo-dev:master-odoo-search-loc-barcode branch to 366e1f7 May 14, 2016

@@ -4,3 +4,4 @@
import test_product
import test_warehouse
import test_shipment
from . import test_stock_location_search

This comment has been minimized.

Copy link
@Yenthe666

Yenthe666 May 15, 2016

Collaborator

@moylop260 you could just do import test_stock_location_search instead of doing from . import test_stock_location_search?

This comment has been minimized.

Copy link
@moylop260

moylop260 May 15, 2016

Author Contributor

What is your reference for this request?

Could you check the following pep https://www.python.org/dev/peps/pep-0328/#rationale-for-relative-imports?

This comment has been minimized.

Copy link
@Yenthe666

Yenthe666 May 15, 2016

Collaborator

@moylop260 since all other tests are imported without from . I was thinking it would be cleaner to keep them all the same, since otherwise you have both import test_product and from . import test_stock_location_search.
@mart-e what do you think?

This comment has been minimized.

Copy link
@moylop260

moylop260 May 15, 2016

Author Contributor

@Yenthe666
My example module is account account/tests/__init__.py

You can find more examples of relative import running
rgrep "from . import" ./addons/*/tests --include=__init__.py

screen shot 2016-05-15 at 11 27 59 am

This comment has been minimized.

Copy link
@Yenthe666

Yenthe666 May 15, 2016

Collaborator

@moylop260 I actually didn't notice this, thanks for pointing this out! Sorry for this. :)

@HairBear22

This comment has been minimized.

Copy link

commented Jun 22, 2017

So what's the status of this? Did it ever get implemented? I'm looking for the same functionality.

@mart-e mart-e self-assigned this Jun 23, 2017

@mart-e mart-e added the Logistics label Jun 23, 2017

@mart-e

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2017

Sorry we missed this. It is actually a good addition.
Rebased, a bit adapted and merged at 4a3699b

@mart-e mart-e closed this Jun 23, 2017

mart-e added a commit that referenced this pull request Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.