[FIX] project: Don't reset partner_id in onchange_project when empty #15025

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pedrobaeza
Contributor

In 3041efb, it was introduced a partner_id reset when project_id is False, but this causes you can't apply default values to partner_id directly.

One use case where happens:

  • Go to Sales > Customers.
  • Select one customer.
  • Click on the smart-button "Tasks".
  • Create new task.

Before this commit, the customer where you come from is assigned.
After this, no partner is selected.

@pedrobaeza pedrobaeza [FIX] project: Don't reset partner_id in onchange_project when empty
In 3041efb, it was introduced a partner_id reset when project_id is
False, but this causes you can't apply default values to partner_id
directly.

One use case where happens:

* Go to Sales > Customers.
* Select one customer.
* Click on the smart-button "Tasks".
* Create new task.

Before this commit, the customer where you come from is assigned.
After this, no partner is selected.
2b6e00b
@pedrobaeza
Contributor
@pedrobaeza
Contributor

@sle-odoo, you were the one that introduces the bug. Can you please check?

@pedrobaeza
Contributor

@mart-e, maybe you can check this one

@sle-odoo
Contributor

@pedrobaeza what do you think of odoo-dev@5b7fbc4? with this patch, when switching projects you do not risk to set on the task the partner_id defined on the previously selected project.

@pedrobaeza
Contributor

Thanks for your fast reply, Simon! I'm checking and putting comments in the commit itself.

@sle-odoo
Contributor

do you agree with odoo-dev@31930ff ?

@pedrobaeza
Contributor

Yes, perfect!!

Thank you very much.

@sle-odoo
Contributor

merged at 3aa7b8c
thank you

@sle-odoo sle-odoo closed this Jan 11, 2017
@pedrobaeza pedrobaeza deleted the Tecnativa:9.0-project-task_onchange_project_id-fix branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment