[CLA] Update Contributors List #15568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cesar Rodriguez is not part of BACG Organization
ADD Osvaldo Jorge Gentile to Bacgroup Organization
[CLA] ADD Osvaldo Jorge Gentile to Bacgroup
|
The user "leodipasquale" is already bacgroup CLA. |
|
Please review |
|
Also (Osvaldo Jorge Gentile) Added to Bacgroup CLA |
|
Hello, Thank you for the CLA signature but it seems there is still an issue.
The email address in the CLA must be the same as for the signature for the verification to succeed. Thanks |
|
salvatoretrimarchi update principal email address to trimarchi@bacgroup.net |
|
sorry, my email was not public, now it is. dipasquale@bacgroup.net |
|
@leodipasquale @salvatoretrimarchi to update your CLA, you must make commits with the emails signing the CLA. |
|
To update CLA, you need new commits in this pull request or do them in new pull request? |
|
Either you rebase & squash all commits with the correct email in this PR or you create a new one with only one commit, as you wish |
* [FIX] stock: Customer address in deliveryslip When there is no move line linked to the picking, the customer address must be the address of the partner linked to the stock.pick Fixes #15092 opw:707890 * [FIX] base: default partner email In a lead: - Fill in contact information (phone, address, email...) - Create a new contact All information is copied to the new contact, except the email. opw-706711 * [FIX] hr_timesheet: recomputation depends of the task progress The task progress value depends on the stage of the task, if it's a folded stage or not. If the task was being changed of stage, from a non-folded stage to a folded stage, the recomputation of the progress was not done, while it was needed as a task in a final stage is considered to be done. This is a regression during migration to the new api in e6ac7a7 * [FIX] hr_timesheet: children_hours computation The computation of the `children_hours` wasn't reset at each compute, and they ended up to be added at each recomputation involving the method `_hours_get` This is a regression during migration to the new api in revision e6ac7a7 opw-709008 * [FIX] hr_timesheet: computation of the children hours according to the child stage The below revision: 9bea8a8 Change the behavior on how are computed the children hours according to their stage fold state, while it was not intended to. The subject of the above revision was an issue in the recomputation dependence for the field `children_hours`, but not how the field was computed. It's important to count the effective hours when the sub task is in a final stage (e.g. done) rather than the planned hours in this case. opw-709008 * [FIX] hr_payroll: calculation of work days The current calculation of work days is inconsistent with the leaves of the employee in several cases. The core of the problem is the logic of the algorithm: for a given day, if we can find one hr_holiday within this day, we consider it as a leave. One can easily spot several issues with the existing logic: - if an employee takes less than a day-off (e.g. a half day), the complete day is considered as a leave. - the timezone (TZ) is not taken into account when searching for a leave, while it is when computing the number of working hours. A leave from 3:00 AM to 3:00 PM in the Los Angeles timezone would then be considered as two days-off since it spread on two days in UTC. The logic is therefore completely modified. For each day of the period: - compute the work intervals (TZ taken into account, converted in UTC) - search for a hr.holiday which completely includes the work interval - if a holiday is found, the work interval is considered as a leave. Otherwise, it is considered as a normal work period. This is a first step in improving the logic. The first faulty use case is partially solved, since we cover now complete work intervals. However, a leave covering only partially a work interval will not be taken into account. The second faulty use case is solved. opw-707897 * [CLA] Update Bacgroup Member List
|
This PR is a mix of many unrelated commits. |
|
Understood, no problem we going to create new pull request for this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cesar Rodriguez is not part of BACG Organization
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr