[FIX] account: use max_date instead of create_date for aged reports #16016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smetl
force-pushed
the
master-aged-reports-las
branch
from
92e53f4
to
96a59fb
Compare
Aged receivable/payable uses create_date of account_partial_reconcile to decide if a partner needs to be shown at a given date or note. It can be problematic in some case where reconciliation is done at date X and account.move date is Y, as this will be confusing in the aged receivable/payable report. For example, an invoice dated 30-12-2016 and due the same day but paid the 01-01-2017. The customer appeared on the aged receivable in 2017 instead of the last financial year as 31-01-2016. -opw: 31844
smetl
force-pushed
the
master-aged-reports-las
branch
from
96a59fb
to
6997486
Compare
qdp-odoo
requested changes
Mar 28, 2017
qdp-odoo
pushed a commit
that referenced
this pull request
Apr 11, 2017
Aged receivable/payable was using create_date of account_partial_reconcile to decide if a partner needs to be shown at a given date or not. While it was not wrong, our decision to use the create_date was based on the fact that we wanted to be able to render the exact same report we had at a past date, so a the date of the reconciliation would be important... but since the unreconciliation was not forbidden it wasn't really the case. Moreover, in some case where reconciliation is not at the same time the payment is recorded, this choice - was confusing people about results given by the aged receivable/payable report. - was confusing people about the 'Paid on...' line in the payment widget on the invoice, as they would see there a date unused by the system (although they would have liked too) This was discussed in opw 31844. Was PR #16016
|
landed on master at revision a8994b4 |
ddufresne
pushed a commit
to ddufresne/odoo
that referenced
this pull request
Mar 14, 2018
Aged receivable/payable was using create_date of account_partial_reconcile to decide if a partner needs to be shown at a given date or not. While it was not wrong, our decision to use the create_date was based on the fact that we wanted to be able to render the exact same report we had at a past date, so a the date of the reconciliation would be important... but since the unreconciliation was not forbidden it wasn't really the case. Moreover, in some case where reconciliation is not at the same time the payment is recorded, this choice - was confusing people about results given by the aged receivable/payable report. - was confusing people about the 'Paid on...' line in the payment widget on the invoice, as they would see there a date unused by the system (although they would have liked too) This was discussed in opw 31844. Was PR odoo#16016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aged receivable/payable uses create_date of account_partial_reconcile to decide if a partner needs to be shown at a given date or note.
It can be problematic in some case where reconciliation is done at date X and account.move date is Y, as this will be confusing in the aged receivable/payable report.
For example, an invoice dated 30-12-2016 and due the same day but paid the 01-01-2017.
The customer appeared on the aged receivable in 2017 instead of the last financial year as 31-01-2016.
-opw:
https://www.odoo.com/web#id=31844&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr