Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fields: recompute recursive stored fields #16370

Merged
merged 1 commit into from Apr 11, 2017

Conversation

rco-odoo
Copy link
Member

Stored computed fields that recursively depend on themselves are not recomputed as expected.
The trigger to recompute them is simply missing.

@rco-odoo rco-odoo requested a review from KangOl April 11, 2017 09:58
@rco-odoo rco-odoo added the RD research & development, internal work label Apr 11, 2017
@KangOl
Copy link
Contributor

KangOl commented Apr 11, 2017

In version 10.0?

@rco-odoo
Copy link
Member Author

@KangOl the code that adds recomputation triggers has been refactored a bit before 10.0.
I may backport this fix to 8.0 or 9.0, but it will look somewhat different.

Copy link
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for 10.0 then.

@simahawk
Copy link
Contributor

I had this same issue on v9 a long time ago and I was forced to define a huge depends to support at least 4 levels of parent/children. Thanks for fixing this! Having this on v9 too would be nice indeed :)

@rco-odoo rco-odoo force-pushed the 10.0-recursive-recompute-rco branch from fdc6b5e to 3481f0f Compare April 11, 2017 13:34
@rco-odoo rco-odoo merged commit 3481f0f into odoo:10.0 Apr 11, 2017
@rco-odoo rco-odoo deleted the 10.0-recursive-recompute-rco branch April 11, 2017 13:35
@rco-odoo
Copy link
Member Author

@simahawk I backported the fix to 9.0 in rev 4f98311.

@simahawk
Copy link
Contributor

great! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants