[CLA] add jesuszapata to Vauxoo's CLA #17237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related with #17236 |
|
cc @moylop260 |
Jerther
added a commit
to metalsartigan/odoo
that referenced
this pull request
May 29, 2017
* [FIX] point_of_sale: do not recompute the past The cash_control flag on a session will be true if at least one payment method is cash and the config has cache control. However, the prevents to enable the flag on the config if one session in the past had no cash method. As the field is not stored, it will be recomputed if displayed (or prefetched) and raise an error, on a past session. If the session is already closed, never raise an error opw-744314 * [CLA] signature for bimajatiwijaya Done at odoo#17087 * [DOC] doc: remove kanban_text_ellipsis description views.rst: replace the description of js function kanban_text_ellipsis() with a warning telling it's gone and what to use instead. * [I18N] Update translation terms from Transifex * [FIX] purchase: prevent rounding during currency conversion With the settings: - Anglo saxon accounting - real price on product, perpetual accounting, - multicurrency - a product with a very small uom (like gram or kilograms and you want to sell many of them, like 500kg) Flow: purchasing something in another currency Before this commit, the rounding of the unit price took place right at the conversion level which led the rounding errors to be amplified by the quantities when the total price was computed After this commit, the conversion is done on the unit price but is not rounded yet Only the prices are rounded, as late as possible OPW 742293 Closes odoo#17015 * [FIX] payment: untranslated message Without this the error message will always be in English, no matter the language of the end-user. Closes odoo#17141 * [FIX] website_sale: add support for decimal_precision = 0 Before this commit data-precision='0' was ignored by qweb rendering. Now we force the data-precision to be set even if 0. (cast in str) And add a temporary fallback JS side to catch this case while people don't update the qweb template. This commit closes odoo#17050 and closes odoo#17046 * [I18N] payment: correctly format pot Introduced at c80a32f * [FIX] web_editor: inline space in source code The prettifying of html when editing sources (user need to be in debug mode to see the button) was removing too much spaces in some instances. For example if someone got in a case such as: <span>hello<b> cruel </b>world!</span> The spaces between text and tag would be removed (this would work fine with the space outside of the tag). This code add a special case so this doesn't happen anymore. opw-743565 closes odoo#17142 * [FIX] website: The default language does not use the configuration The request language must be a fallback if the current website does not have a default language * [CLA] update Vauxoo's CLA add gavymg Done at odoo#17148 * [FIX] l10n_mx: wrong cash_basis_account for purchase taxes Was PR odoo#15893 * [FIX] membership: invoice tree view When a membership is created, a redirection is done to the tree view of the vendor bills. It should be the tree view of the customer invoices. opw-743241 * [FIX] stock: display variant fields on variant form The structure of the product.{product,template} form is the following: product.product_template_form_view* (both) |-- product.product_template_only_form_view* (template) | \-- stock.product_template_form_view_procurement_button | |-- product.product_normal_form_view* (product) | \-- stock.product_form_view_procurement_button | \-- stock.view_template_property_form (both) Previous view was adding weight, volume fields on both view with a attrs that applies only to the product.template (display only if no template). This means that the weight was not displayed on product.product form if opened from a Many2one (using the default product.product view) while the attrs should not hide it. Closes odoo#16541 Fixes odoo#16428 * [FIX] base: include installed module in inheriting views retrival In a scenario with the following views: Mod A, view 1* |-- Mod B, view 2 \-- Mod B, view 3* view 3 can not rely on the elements added by view 2 in xpath If view 3 is a primary view, view 1 must be fully resolved first (apply view 2) before resolving view 3. Next commit describes a real use-case with product. Linked to odoo#16541 and odoo#16428 * [FIX] web_editor: properly match snippet options' DOM The snippet options are attached to `closest`, `all` and `is` functions to be able to find/check DOM they are associated to. Their behavior depend on the snippet option type: the search in the DOM is either done in the body, the editable parts, the editable children only, .... The problem is that when searching from a given DOM element, jQuery won't match the elements whose selector contains this given DOM element. Or in code terms, jQuery find function behavior is: `$('A').find('A B')` <=> `$('A A B')` (not `$('A B')`) This was indeed a problem on the job position apply form pages where the main editable element is the <form/> element itself. Indeed, the snippet options' selectors which began by 'form' were not able to match. Worse, the selector is used for a jQuery search for drag & drop and saving but not for initialization (where it is used as a `is` check on clicked elements). So, some DOM were able to be modified by options but not properly (re)configured before saving. opw-705902 opw-741305 * [FIX] account: writeoff sign - Set-up multi-currency with the following rates: MXN: 1.0 USD (2017-04-10): 0.052632 USD (2017-04-27): 0.051680 - Create an invoice of 1779.55 USD on 2017-04-10 - Register a payment of 1779.48 USD on 2017-04-27 - Set the invoice as fully paid It is impossible to validate the payment because of the following error: "The amount expressed in the secondary currency must be positive when account is debited and negative when account is credited." We make sure to align the writeoff amount sign with the writeoff amount sign in the company currency. opw-741520 * [FIX] account: revert 6de2990 and proper fix Revert "[FIX] account: reset the move reference on bank statement" This reverts commit 6de2990. The previous patch was removing the reference of the move. However, the reference is useful to reuse the name if the line is reconciled again. Instead, remove the constrain. To delete the move, account_cancel is already needed. It is useful to allow removing statement lines to match the statements form the bank and the one on Odoo. In the future, allowing to set the amounts to zero should be added as a way to correct the lines. opw-741205 * [FIX] mail: can't open mail composer on virtual event In the case of a chatter on a calendar virtual event, there was a number of issue because the record ID was of the type "[REAL ID]-[VIRTUAL ID]". This caused issue when fetching and posting message with the composer. opw-744405 closes odoo#17179 * [FIX] account: children in Invoiced partner button When we are on a partner form view, we get the total invoiced containing the child contact of the current partner. But when clicking the button we only see the invoices of exactly the current partner. In most locations of the code this has changed (since 347c784) and this part should also contain the descendants contacts. opw-744929 closes odoo#17188 * [CLA] signature for sum1201 Done at odoo#17211 * [FIX] purchase: hook to allow override of domain Add a hook to allow the hardcoded domain in the method `make_po`, in procurement order. Base on work by @Cedric-Pigeon opw-744606 Closes odoo#17147 * [FIX] account: untranslated string Closes odoo#17133 Closes odoo#17137 * [I18N] account: export source terms Was pretty outdated * [I18N] sale: update source terms Recent changes in mail.templates not reflected * [CLA] Add Benjamin Willig in ACSONE CCLA Done at odoo#17232 * [FIX] sale_stock: access to sale orders Make sure the user has access to all sale orders linked to this procurement group. Fixes and closes odoo#17232 * [I18N] Update translation terms from Transifex * [FIX] crm: expected closing The "exp. closing" dashboard button takes into account the won opportunities. It shouldn't. opw-744940 * [FIX] point_of_sale: _confirm_orders To help users to know why they can't close their pos sessions when a Sales Journal is not set in the pos.config. opw:744758 * [FIX] analytic: Remove search default non existent Courtesy of cubells (Orbetix). Was PR odoo#17219 * [FIX] payment: untranslated string Closes odoo#17256 * [FIX] l10n_be_invoice_bba: Display warning in user's language * [FIX] hr_expense: untranslated string Closes odoo#17255 * [FIX] base: Correct typos for 2 spanish states Closes odoo#17251 * [CLA] corporate signature for landoo odoo#17251 * [FIX] payment_authorize: add missing translation ability Closes odoo#17257 * [FIX] hr_expense: remove duplicated field Courtesy of Yenthe * [FIX] stock: missing grand total for inventory valuation (was working in Odoo 9.0) * [FIX] hr_timesheet_sheet: Display warning in user's language Closes https://github.com/odoo/odoo/pull/17254/files * [CLA] add JesusZapata to Vauxoo's CLA (odoo#17237) Closes odoo#17237 * [IMP] l10n_do: Add CoA missing accounts, add tags Description of the issue/feature this PR addresses: The Chart of Accounts was missing accounts needed for correct inventory valuation using perpertual method, and also a seggregation for payroll accounts, to differ employee retentions from company contributions. Current behavior before PR: Wrong accounts used for perpetual inventory valuation Payroll accounts not showing difference between employee retentions and company contributions Regulatory reports are hard to make without the right accounts tag Desired behavior after PR is merged: The correct accounts are now created and assigned for inventory valuation. And payroll accounts are correctly segregated for the payroll rules coming in the next PR. The accounts will also have their corresponding tags for having regulatory reports based on the "control account" for hierarchy, which was removed in v8. This changes are also needed for a WIP of a PR coming to the Enterprise repository, for building legal reports based on account and tax tags. * [FIX] l10n_do: Add 18% tax to Communication tax group When changing the 18 tax by the communication group, the 18 tax has to remain * [FIX] l10n_do: Remove useless and unknown field `spoken_langages` This field is used with the multilang module. As only one language is spoken in Dominican Republic, this definition is useless and furthermore it raises a warning in the logs. * [FIX] pos_mercury: Display warning in user's language Closes odoo#17261 * [CLA] add goliveirab to Vauxoo's CLA Done at odoo#17200 * [FIX] website_sale: do not display unavailable pricelists It should not be possible via /shop/change_pricelist/<pl_id> to change to a pricelist that is not marked as selectable. is_pricelist_available method should do that, but is not, because it calls get_pricelist_available with show_visible=True, instead of show_visible=False :param bool show_visible: if True, we don't display pricelist where selectable is False (Eg: Code promo) Closes odoo#17220 * [IMP] doc: add missing doc on kanban groups group_create, group_delete and group_edit were missing Closes odoo#17218 * [FIX] mrp: format date in user format Instead of hardcoded YYYY-MM-DD t-options was introduced in 10.0 Fixes odoo#12341 * [FIX] account: search account.journal also by shortcode OPW 744362 odooGH-17102 Closes odoo#17178 * [FIX] product: Display the variants in the same order for one product Currently the variants are ordered by the attribute value in the name_get. That way, all the attributes aren't displayed in the same order. Ordering by the variant attribute name will solve this issue. Closes odoo#17034 * [FIX] purchase_requisition: fix taxes_id field being created with records instead of ids Fixes odoo#16222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name: Jesus Zapata
E-mail: jesus@vauxoo.com
GitHub user: https://github.com/JesusZapata