Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 3, 2025

Before this commit, it was possible to have a videoError caused by (or happening during) the destruction of the video component.

This error should not be retained as playing the video is no longer useful when the component is destroyed.

Forward-Port-Of: #204518
Forward-Port-Of: #204470

@robodoo
Copy link
Contributor

robodoo commented Apr 3, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 3, 2025

This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 3, 2025
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 3, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 3, 2025

@ThanhDodeurOdoo @phenix-factory ci/runbot failed on this forward-port PR

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 7, 2025

@ThanhDodeurOdoo @phenix-factory the next pull request (#204941) is in conflict. You can merge the chain up to here by saying

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 11, 2025

@ThanhDodeurOdoo @phenix-factory this forward port of #204470 is awaiting action (not merged or closed).

@ThanhDodeurOdoo
Copy link
Member

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Apr 11, 2025

@ThanhDodeurOdoo @phenix-factory staging failed: ci/runbot on 47e609c078037e91716ab715b6e5a56da4eff8e6 (view more at https://runbot.odoo.com/runbot/build/78182172)

@ThanhDodeurOdoo
Copy link
Member

@robodoo retry

@robodoo
Copy link
Contributor

robodoo commented Apr 11, 2025

@ThanhDodeurOdoo @phenix-factory staging failed: ci/runbot on 9af4bdffa80fbb75cb609b4da8b30a45ba7b6c05 (view more at https://runbot.odoo.com/runbot/build/78187310)

Before this commit, it was possible to have a `videoError` caused by
(or happening during) the destruction of the video component.

This error should not be retained as playing the video is no longer
useful when the component is destroyed.

X-original-commit: 941306a
@alexkuhn alexkuhn force-pushed the 18.0-17.0-call-video-error-fix-tso-427271-fw branch from c70969a to 55bc56a Compare April 13, 2025 21:55
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 13, 2025

@ThanhDodeurOdoo @phenix-factory this PR was modified / updated and has become a normal PR. It must be merged directly.

@alexkuhn
Copy link
Contributor

@robodoo r+

@C3POdoo C3POdoo requested review from a team April 13, 2025 21:57
robodoo pushed a commit that referenced this pull request Apr 13, 2025
Before this commit, it was possible to have a `videoError` caused by
(or happening during) the destruction of the video component.

This error should not be retained as playing the video is no longer
useful when the component is destroyed.

closes #204642

X-original-commit: 941306a
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 14, 2025

@ThanhDodeurOdoo @phenix-factory @alexkuhn staging failed: ci/runbot on 2c7d26e5551cb278b5cde46e76e9609dea939f9d (view more at https://runbot.odoo.com/runbot/build/78328631)

@ThanhDodeurOdoo
Copy link
Member

@robodoo retry

@robodoo robodoo closed this in 7593c4f Apr 14, 2025
@alexkuhn alexkuhn deleted the 18.0-17.0-call-video-error-fix-tso-427271-fw branch April 14, 2025 08:20
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Apr 26, 2025
Before this commit, it was possible to have a `videoError` caused by
(or happening during) the destruction of the video component.

This error should not be retained as playing the video is no longer
useful when the component is destroyed.

closes odoo/odoo#204642

X-original-commit: 941306a0ebae13e0b39672a82a99bb0707a489ff
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forwardport This PR was created by @fw-bot RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants