-
Notifications
You must be signed in to change notification settings - Fork 30.2k
[FW][FIX] discuss: prevent warning for expected video error #204642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] discuss: prevent warning for expected video error #204642
Conversation
|
This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@ThanhDodeurOdoo @phenix-factory ci/runbot failed on this forward-port PR |
|
@ThanhDodeurOdoo @phenix-factory the next pull request (#204941) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@ThanhDodeurOdoo @phenix-factory this forward port of #204470 is awaiting action (not merged or closed). |
|
@robodoo r+ |
|
@ThanhDodeurOdoo @phenix-factory staging failed: ci/runbot on 47e609c078037e91716ab715b6e5a56da4eff8e6 (view more at https://runbot.odoo.com/runbot/build/78182172) |
|
@robodoo retry |
|
@ThanhDodeurOdoo @phenix-factory staging failed: ci/runbot on 9af4bdffa80fbb75cb609b4da8b30a45ba7b6c05 (view more at https://runbot.odoo.com/runbot/build/78187310) |
Before this commit, it was possible to have a `videoError` caused by (or happening during) the destruction of the video component. This error should not be retained as playing the video is no longer useful when the component is destroyed. X-original-commit: 941306a
c70969a to
55bc56a
Compare
|
@ThanhDodeurOdoo @phenix-factory this PR was modified / updated and has become a normal PR. It must be merged directly. |
|
@robodoo r+ |
Before this commit, it was possible to have a `videoError` caused by (or happening during) the destruction of the video component. This error should not be retained as playing the video is no longer useful when the component is destroyed. closes #204642 X-original-commit: 941306a Signed-off-by: Didier Debondt (did) <did@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
|
@ThanhDodeurOdoo @phenix-factory @alexkuhn staging failed: ci/runbot on 2c7d26e5551cb278b5cde46e76e9609dea939f9d (view more at https://runbot.odoo.com/runbot/build/78328631) |
|
@robodoo retry |
Before this commit, it was possible to have a `videoError` caused by (or happening during) the destruction of the video component. This error should not be retained as playing the video is no longer useful when the component is destroyed. closes odoo/odoo#204642 X-original-commit: 941306a0ebae13e0b39672a82a99bb0707a489ff Signed-off-by: Didier Debondt (did) <did@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before this commit, it was possible to have a
videoErrorcaused by (or happening during) the destruction of the video component.This error should not be retained as playing the video is no longer useful when the component is destroyed.
Forward-Port-Of: #204518
Forward-Port-Of: #204470