[FIX] website_slides: All Courses result dropdown below search #206909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Scenario: go to homepage > Courses > one "View all" > type in search Result: dropdown with result is shown over the search input Issue: search form is in flex layout, but the dropdown is displayed in absolute so it is outside of flex flow and is positionned at the top-right of the form container. History: - before bootstrap 4 (odoo 15): the search form had a flex layout, but bootstrap dropdown used "top:100%" so were positionned at the bottom of it. - as of bootstrap 5 (odoo 16): the form kept a flex layout, but bootstrap dropdown now used "position: absolute" with unset top putting them below the search item in a block container, but over it in a flex layout. Fix: when the search bar is displayed, display it as block. opw-4735257
nle-odoo
force-pushed
the
16.0-website-slides-opw-4735257-nle
branch
from
c798362 to
056b773
Compare
Contributor
Author
|
@odoo/rd-sm-learn what do you think about this? I have updated the target from 16.0 to 17.0 since 16.0 is unsupported The issue also doesn't happen since 19.0 since this has been refactored (eg. robodoo up to saas-18.4 |
Contributor
|
Forward-porting to 'saas-18.4'. |
Contributor
Author
|
@flch-odoo what do you think about this? thanks |
flch-odoo
approved these changes
Nov 26, 2025
robodoo
pushed a commit
that referenced
this pull request
Nov 26, 2025
Scenario: go to homepage > Courses > one "View all" > type in search Result: dropdown with result is shown over the search input Issue: search form is in flex layout, but the dropdown is displayed in absolute so it is outside of flex flow and is positionned at the top-right of the form container. History: - before bootstrap 4 (odoo 15): the search form had a flex layout, but bootstrap dropdown used "top:100%" so were positionned at the bottom of it. - as of bootstrap 5 (odoo 16): the form kept a flex layout, but bootstrap dropdown now used "position: absolute" with unset top putting them below the search item in a block container, but over it in a flex layout. Fix: when the search bar is displayed, display it as block. opw-4735257 closes #206909 Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
This was referenced Nov 26, 2025
khsr-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 27, 2025
Scenario: go to homepage > Courses > one "View all" > type in search Result: dropdown with result is shown over the search input Issue: search form is in flex layout, but the dropdown is displayed in absolute so it is outside of flex flow and is positionned at the top-right of the form container. History: - before bootstrap 4 (odoo 15): the search form had a flex layout, but bootstrap dropdown used "top:100%" so were positionned at the bottom of it. - as of bootstrap 5 (odoo 16): the form kept a flex layout, but bootstrap dropdown now used "position: absolute" with unset top putting them below the search item in a block container, but over it in a flex layout. Fix: when the search bar is displayed, display it as block. opw-4735257 closes odoo#206909 Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: go to homepage > Courses > one "View all" > type in search
Result: dropdown with result is shown over the search input
Issue: search form is in flex layout, but the dropdown is displayed
in absolute so it is outside of flex flow and is positionned at the
top-right of the form container.
History:
before bootstrap 4 (odoo 15): the search form had a flex layout, but
bootstrap dropdown used "top:100%" so were positionned at the bottom
of it.
as of bootstrap 5 (odoo 16): the form kept a flex layout, but
bootstrap dropdown now used "position: absolute" with unset top
putting them below the search item in a block container, but over
it in a flex layout.
Fix: when the search bar is displayed, display it as block.
opw-4735257