Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master yml yti #20890

Merged
merged 15 commits into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@tivisse
Copy link
Contributor

commented Nov 13, 2017

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@tivisse tivisse force-pushed the odoo-dev:master-yml-yti branch 3 times, most recently Nov 13, 2017

@C3POdoo C3POdoo added the RD label Nov 13, 2017

@mreficent

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

❤️❤️❤️❤️❤️❤️❤️❤️❤️

keep with this nice work 👊

@tivisse tivisse force-pushed the odoo-dev:master-yml-yti branch 7 times, most recently Nov 14, 2017

@tivisse tivisse requested a review from rco-odoo Nov 15, 2017

@tivisse

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2017

@rco-odoo Could you please review the commit e70128f

It's about the yml engine removal.

Thanks.

@tivisse

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2017

Thanks @mreficent :)

@tivisse tivisse force-pushed the odoo-dev:master-yml-yti branch 5 times, most recently Nov 15, 2017

@rco-odoo
Copy link
Member

left a comment

Looks good 👍
SImply check the two points in comments.


<!-- Use database uuid as client_id for OpenERP oauth provider -->
<function model="auth.oauth.provider" name="write">
<value eval="[ref('auth_oauth.provider_openerp')]"/>

This comment has been minimized.

Copy link
@rco-odoo

rco-odoo Nov 16, 2017

Member

simpler as

<value ref="auth_oauth.provider_openerp"/>

This comment has been minimized.

Copy link
@tivisse

tivisse Nov 16, 2017

Author Contributor

En fait, non ça ne marche pas :)

odoo/tests/addons/test_translation_import/tests/__init__.py Outdated
@@ -1,4 +1,4 @@
# -*- coding: utf-8 -*-

from . import test_term_count

from . import test_translation_import

This comment has been minimized.

Copy link
@rco-odoo

tivisse and others added some commits Nov 7, 2017

[IMP] test_translation_import: Remove tests.yml
The test is already implemented in python in 'odoo/tests/addons/test_translation_import/tests/test_term_count.py'
[IMP] account_asset: Remove demo data
Purpose
=======

As there's no 'xfa_account_id' configured on the module installation, the demo data are not created.

Specification
=============

Remove them.
[FIX] stock: Fix strange ORM bidouille on picking creation
Purpose
=======

This bidouille on the ORM command seems to be from another age where the onchange on o2m list were not working well.

The issue is that _convert_to_write could return commands like (6, 0, []).

In that case the last tuple element is not dictionary, but a list.

Specification
=============

Fix that brol.
[IMP] stock: Log if a method doesn't exist when running scheduler
Purpose
=======

If a method doesn't exist when running scheduler, log an error instead of raising an AttributeError

The goal of a cron method is to go ad far as possible.

@tivisse tivisse force-pushed the odoo-dev:master-yml-yti branch to 77eb1f8 Nov 16, 2017

@tivisse tivisse merged commit 77eb1f8 into odoo:master Nov 16, 2017

1 of 2 checks passed

ci/runbot runbot build 278900-20890-77eb1f
Details
legal/cla Yannick Tivisse Odoo CLA signature check
Details

@tivisse tivisse deleted the odoo-dev:master-yml-yti branch Nov 16, 2017

@alexkuhn

This comment has been minimized.

Copy link
Contributor

commented on cbbd9c4 Dec 28, 2017

tools.config['without_demo'] is set to True only if we use --without-demo=true through cli.

If we use the html form on /database/selector, and we untick the option 'load demo data', it crashes due to account.demo_stock_account not being defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.