Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail: bounce email going directly to catchall when they are no … #21042

Merged
merged 1 commit into from Dec 15, 2017

Conversation

@tde-banana-odoo tde-banana-odoo added the RD research & development, internal work label Nov 17, 2017
body = """<div>
<p>Hello,</p>
<p>The following email sent to %s cannot be accepted because this is a catchall email
used to collect replies. BLAH BLAH BLAH</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blah blah blah ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I wonder if boom boom boom boom boom if not better.

@tde-banana-odoo tde-banana-odoo force-pushed the master-mail-catchall-warn-tde branch 2 times, most recently from ee60270 to 3787d2a Compare November 21, 2017 14:25
@tde-banana-odoo tde-banana-odoo merged commit 0ae1575 into odoo:master Dec 15, 2017
@wtaferner
Copy link
Contributor

@tde-banana-odoo
It is safe to backport this?

@tde-banana-odoo tde-banana-odoo deleted the master-mail-catchall-warn-tde branch December 15, 2017 11:53
@tde-banana-odoo
Copy link
Contributor Author

Hello,

Well at first sight I would say you have to protect yourself against the new template not being present in the database (mail.mail_bounce_catchall) unless the mail module is updated.

A method has its API that changes (_routing_create_bounce_email) but as it is an internal method it should not be inherited. In official addons there is no override of this method.

Remember I am a dev for master, not someone working on stable or even production instances, so I will let you ask it to smart people :) .

@wtaferner
Copy link
Contributor

wtaferner commented Dec 15, 2017

Haha, I think I have already the most qualified answer to my question.

I summarize as following:
If you do it right for your instances it is safe, but if you have no clue what you are doing please do not use it in stable :-)

Do you agree with my translation? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants