[FIX] website: form inputs without label are still sent #225545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
dabo-odoo
force-pushed
the
17.0-form-input-without-label-are-sent-dabo
branch
2 times, most recently
from
08e278c to
da926f2
Compare
SergeBayet
requested changes
Oct 1, 2025
Contributor
SergeBayet
left a comment
SergeBayet
left a comment
There was a problem hiding this comment.
Thanks @dabo-odoo . Some remarks though. See below. 👍
dabo-odoo
force-pushed
the
17.0-form-input-without-label-are-sent-dabo
branch
from
da926f2 to
3bb0770
Compare
Contributor
|
@dabo-odoo You can put your task as ready to review and send it to india for review. |
Before this commit, a form input without a label would not send its data when clicking send. Steps to reproduce - go to the website editor - add a form - choose any field - delete the field label - save and exit the editor - now in the website, fill the form and click send => the fields without a name label are not sent After this commit fields without a label get sent with a placeholder "unknown_field" task-5062575
robinlej
force-pushed
the
17.0-form-input-without-label-are-sent-dabo
branch
from
3bb0770 to
c80173f
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 27, 2025
Before this commit, a form input without a label would not send its data when clicking send. Steps to reproduce - go to the website editor - add a form - choose any field - delete the field label - save and exit the editor - now in the website, fill the form and click send => the fields without a name label are not sent After this commit fields without a label get sent with a placeholder "unknown_field" task-5062575 closes #225545 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This was referenced Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, a form input without a label would not send its data when clicking send.
Steps to reproduce
After this commit fields without a label get sent with a placeholder "unknown_field"
task-5062575