Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] web: add edit and delete option in many2manytags widget #22957

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@dep-odoo
Copy link
Contributor

commented Feb 9, 2018

Task: https://www.odoo.com/web#id=29227&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
Pad: https://pad.odoo.com/p/r.bd028474aa7424158a77062cbec9c1c4

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Feb 14, 2018

@C3POdoo C3POdoo added the RD label Feb 15, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch 3 times, most recently Mar 1, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch 3 times, most recently to 1e3a3cb Mar 8, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch from 1e3a3cb Mar 19, 2018

@hmo-odoo hmo-odoo added the Framework label Mar 20, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 22, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 26, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 27, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 27, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 27, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch 2 times, most recently Mar 28, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Mar 29, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Apr 3, 2018

@dep-odoo dep-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Apr 10, 2018

@suh-odoo suh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch 2 times, most recently Oct 26, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Oct 26, 2018

@robodoo robodoo added the CI 🤖 label Oct 26, 2018

@robodoo robodoo removed the CI 🤖 label Oct 29, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Oct 29, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Oct 29, 2018

@robodoo robodoo added the CI 🤖 label Oct 29, 2018

@suh-odoo suh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Dec 7, 2018

@robodoo robodoo removed the CI 🤖 label Dec 7, 2018

@suh-odoo suh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch Dec 7, 2018

@suh-odoo suh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch to c8db4e3 Dec 7, 2018

suh-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 7, 2018

[ADD] web: add edit tag feature on many2many_tags widget, also provid…
…e no_edit option to remove edit feature from many2many_tags widget

open a customer form from a meeting (to see the address, the phone, etc)
In case of mispelling, etc you need to go to the settings to change a m2m record. Most of the times menu items are hidden so its painful: product attributes, customer tags
the issue is worse in settings: in new settings there is a lot of m2m tag you cannot change from this screen.

with this commit clicking on m2m tag will give Edit option unless no_edit option is explicitly defined in xml view on field, edit form dialog is given to user to edit m2m tag

Related to task odoo#29227
PR  odoo#22957

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Suraj Shukla <suh@odoo.com>

@robodoo robodoo added the CI 🤖 label Dec 7, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch from c8db4e3 to a5f76cc May 9, 2019

@robodoo robodoo removed the CI 🤖 label May 9, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-web-m2m-edit-dep branch from a5f76cc to fcb45b2 May 10, 2019

@robodoo robodoo added the CI 🤖 label May 10, 2019

[ADD] web: add edit tag feature on many2many_tags widget, also provid…
…e no_edit option to remove edit feature from many2many_tags widget

open a customer form from a meeting (to see the address, the phone, etc)
In case of mispelling, etc you need to go to the settings to change a m2m record. Most of the times menu items are hidden so its painful: product attributes, customer tags
the issue is worse in settings: in new settings there is a lot of m2m tag you cannot change from this screen.

with this commit clicking on m2m tag will give Edit option unless no_edit option is explicitly defined in xml view on field, edit form dialog is given to user to edit m2m tag

task-29227
PR-22957

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Suraj Shukla <suh@odoo.com>

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-web-m2m-edit-dep branch from fcb45b2 to e4826f0 May 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

@robodoo robodoo removed the CI 🤖 label May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.