Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail: Inline design for schedule activity #23787

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@jat-odoo
Copy link
Contributor

jat-odoo commented Mar 21, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:
Before this commit,
For schedule activity there is button in chatter which open dialog to schedule activity.
Which look like it's not part of composer.

Desired behavior after PR is merged:
After this commit,
Schedule activity is in composer with all fields which are in dialog.
Which look like it's part of same design as send a message or log note.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Mar 21, 2018

@jat-odoo jat-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch Apr 19, 2018

@rga-odoo rga-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch May 9, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch May 24, 2018

@rga-odoo rga-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch 2 times, most recently Jun 1, 2018

@rga-odoo rga-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch 2 times, most recently Jun 28, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch 2 times, most recently to 7b87051 Jul 4, 2018

@msh-odoo

This comment has been minimized.

Copy link
Contributor

msh-odoo commented Jul 4, 2018

LGTM

@rga-odoo rga-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch from 7b87051 Oct 25, 2018

@jat-odoo jat-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch Oct 25, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 25, 2018

[IMP] mail: Inline design for schedule activity
For schedule activity there is button in chatter which open dialog to schedule activity.
Which look like it's not part of composer, to make UI same for all buttons Send message, Log note and Scheduled activity make scheduled activity form inline instead of opening wizard.

web: Also now _onButtonClicked of form_controller will not return deferred result so we can add callback chain properly.

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Ravi Gadhia <rga@openerp.com>

@msh-odoo msh-odoo force-pushed the odoo-dev:master-mail-activity-inline-jat branch to a2fb873 Feb 19, 2019

@robodoo robodoo removed the CI 🤖 label Feb 19, 2019

[IMP]mail: add classes through start method as Controller will always…
… have template(as controller has actionMixin which has 'Action' as template), so we can not directly give className

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

@hmo-odoo

This comment has been minimized.

Copy link
Contributor

hmo-odoo commented Mar 5, 2019

cancelled task

@hmo-odoo hmo-odoo closed this Mar 5, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.