New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] resource calendar #24717

Merged
merged 8 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@rco-odoo
Member

rco-odoo commented May 14, 2018

Fix timezone issues in resource calendar:

  • improve tests on resource calendar and resource mixin;
  • add a required timezone field on models 'resource.calendar' and 'resource.resource' to disambiguate attendances;
  • improve API of 'resource.calendar' and 'resource.mixin' to prevent other modules from using its implementation methods;
  • refactor implementation of 'resource.calendar' to make it more efficient.

@rco-odoo rco-odoo added the RD label May 14, 2018

@rco-odoo rco-odoo requested a review from kujiu May 14, 2018

RomainLibert and others added some commits Apr 9, 2018

[IMP] *: adapt code to new API of resource
Change the calls to resource.calendar and resource.mixin to match the
new API.

Concerned modules are :
  - hr_holidays
  - hr_payroll
  - mrp_workcenter
  - project
  - project_timesheet_holidays
[IMP] resource: add tz on resource.resource
Also make tz required on resource.calendar.
Adapt methods to take the resource's timezone into account.

@rco-odoo rco-odoo merged commit 975c6c8 into odoo:master May 31, 2018

1 check passed

ci/runbot runbot build 333260-24717-80706e (runtime 1561s)
Details

@rco-odoo rco-odoo deleted the odoo-dev:master-resource-calendar-rco branch May 31, 2018

rga-odoo added a commit to odoo-dev/odoo that referenced this pull request Jun 1, 2018

[REF] resource calendar (odoo#24717)
Refactor resource calendar and resource mixin:
 - add a required timezone field on models 'resource.calendar' and 'resource.resource';
 - resource calendar attendances are now computed in the timezone of the resource
   or the calendar;
 - improve API of 'resource.calendar' and 'resource.mixin';
 - avoid other modules from using the implementation methods of 'resource.calendar';
 - refactor implementation of 'resource.calendar' to make it more efficient.

aab-odoo added a commit to odoo-dev/odoo that referenced this pull request Jun 7, 2018

[REF] resource calendar (odoo#24717)
Refactor resource calendar and resource mixin:
 - add a required timezone field on models 'resource.calendar' and 'resource.resource';
 - resource calendar attendances are now computed in the timezone of the resource
   or the calendar;
 - improve API of 'resource.calendar' and 'resource.mixin';
 - avoid other modules from using the implementation methods of 'resource.calendar';
 - refactor implementation of 'resource.calendar' to make it more efficient.

Whenrow added a commit to odoo-dev/odoo that referenced this pull request Sep 4, 2018

[FIX] purchase_requisition: datetime convertion
Purchase agreements create request for quotation with prefilled field. 
The issue is: 
date_planned (on RfQ) is filled from schedule_date (on PA). The first 
one is a datetime object. The second one is a date object.
This commit makes a right convertion between datetime and date at the 
RfQ creation. This issue was introduced by the datetime refactoring 
(odoo#24717)

Task id: 1878136

Whenrow added a commit to odoo-dev/odoo that referenced this pull request Sep 4, 2018

[FIX] purchase_requisition: datetime convertion
Purchase agreements create request for quotation with prefilled field.
The issue is:
date_planned (on RfQ) is filled from schedule_date (on PA). The first
one is a datetime object. The second one is a date object.
This commit makes a right conversion between datetime and date at the
RfQ creation. This issue was introduced by the datetime refactoring
(odoo#24717)

Task id: 1878136

Whenrow added a commit to odoo-dev/odoo that referenced this pull request Sep 4, 2018

[FIX] purchase_requisition: datetime convertion
Purchase agreements create request for quotation with prefilled field.
The issue is:
date_planned (on RfQ) is filled from schedule_date (on PA). The first
one is a datetime object. The second one is a date object.
This commit makes a right conversion between datetime and date at the
RfQ creation. This issue was introduced by the datetime refactoring
(odoo#24717)

Task id: 1878136

Whenrow added a commit that referenced this pull request Sep 5, 2018

[FIX] purchase_requisition: datetime convertion
Purchase agreements create request for quotation with prefilled field.
The issue is:
date_planned (on RfQ) is filled from schedule_date (on PA). The first
one is a datetime object. The second one is a date object.
This commit makes a right conversion between datetime and date at the
RfQ creation. This issue was introduced by the datetime refactoring
(#24717)

Task id: 1878136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment