Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master base currency position rop #25183

Open
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mpa-odoo
Copy link
Contributor

mpa-odoo commented Jun 11, 2018

Description of the issue/feature this PR addresses:
Task: https://www.odoo.com/web?#id=35636&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.11ed19a243459e5cbd148b9c1fe75b4d
Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Jun 11, 2018

@atp-odoo atp-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Jun 11, 2018

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Jun 11, 2018

@atp-odoo atp-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Jun 11, 2018

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Feb 4, 2019

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch Feb 4, 2019

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch to 76b8efa Feb 20, 2019

mpa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 20, 2019

[IMP] base: use currency position and space between amount and curren…
…cy symbol from language

Currency position is something that is dependent
on the language and not the currency as we used
to think. Proof is, it is on the Python locale:
https://docs.python.org/3/library/locale.html?highlight=nl_langinfo#locale.CRNCYSTR

- added 2 new fields on res.lang base on that currency position and space between amount and currency symbol are computed on res.currency
- res.lang data is improved base on locale
- improve currency position base on user specific language in 'fomateLang'and  ir_qweb_fields.
- improve data of res.currency because position is display based on language

Related TaskId: 35636. Closes: odoo#25183.
Co-authored-by: Mitali Patel <mpa@odoo.com>

mpa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 20, 2019

[IMP] mail: set currency position base on user specific language
now need to check for currency space between amount and symbol to display it after or before based on currency position.
Related TaskId: 35636. Closes: odoo#25183.

mpa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 20, 2019

[IMP] web: improved monetary field widget
 currency position set from language of user locale. and we set currency space from language of user locale. so need to check space between currency amount and symbol
 after currency position condition. that's why need to add space on get_currencies to set space between amount and symbol on monetary field widget.

Related TaskId: 35636. Closes: odoo#25183.

mpa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 20, 2019

[IMP] web: parseMonetary: Improve parseMonetary function so that it s…
…upport non breaking space as well as value without non breaking space.

With this change monetary widget can support value without space after or before symbol, even if user enters value with symbol(without space or with non breaking space or normal space) or if user enters value without symbol parseMonetary can not parse all those values
example: 100.00 00.00, 00,000,00.00, $&nbsp;1000.00, $ 100.00, 100.00&nbsp;$, 100.00$ all this values can be parsed

Related TaskId: 35636. Closes: odoo#25183.

Co-authored-by: Mohammed Shekha <msh@openerp.com>

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch 2 times, most recently Feb 21, 2019

rop-odoo and others added some commits Feb 19, 2018

[IMP] base: use currency position and space between amount and curren…
…cy symbol from language

Currency position is something that is dependent
on the language and not the currency as we used
to think. Proof is, it is on the Python locale:
https://docs.python.org/3/library/locale.html?highlight=nl_langinfo#locale.CRNCYSTR

- added 2 new fields on res.lang base on that currency position and space between amount and currency symbol are computed on res.currency
- res.lang data is improved base on locale
- improve currency position base on user specific language in 'fomateLang'and  ir_qweb_fields.
- improve data of res.currency because position is display based on language

Related TaskId: 35636. Closes: #25183.
Co-authored-by: Mitali Patel <mpa@odoo.com>
[IMP] mail: set currency position base on user specific language
now need to check for currency space between amount and symbol to display it after or before based on currency position.
Related TaskId: 35636. Closes: #25183.
[IMP] web: improved monetary field widget
 currency position set from language of user locale. and we set currency space from language of user locale. so need to check space between currency amount and symbol
 after currency position condition. that's why need to add space on get_currencies to set space between amount and symbol on monetary field widget.

Related TaskId: 35636. Closes: #25183.
[IMP] base, sale, website_sale_delivery: change the position of negat…
…ive sign base on locale sign position for ir qweb monetary field
[IMP] web: parseMonetary: Improve parseMonetary function so that it s…
…upport non breaking space as well as value without non breaking space.

With this change monetary widget can support value without space after or before symbol, even if user enters value with symbol(without space or with non breaking space or normal space) or if user enters value without symbol parseMonetary can not parse all those values
example: 100.00 00.00, 00,000,00.00, $&nbsp;1000.00, $ 100.00, 100.00&nbsp;$, 100.00$ all this values can be parsed

Related TaskId: 35636. Closes: #25183.

Co-authored-by: Mohammed Shekha <msh@openerp.com>

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch 2 times, most recently Feb 21, 2019

@mpa-odoo mpa-odoo force-pushed the odoo-dev:master-base-currency-position-rop branch to 5de039b Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.