[FIX] base: remove duplicated translation before update #25787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-e
force-pushed
the
saas-11.2-remove-dup-insert-missing-trans-mat
branch
from
0ab49af
to
1420df8
Compare
|
Can a non-regression test be added? |
mart-e
force-pushed
the
saas-11.2-remove-dup-insert-missing-trans-mat
branch
from
cf5a4f9
to
4ed4d4a
Compare
|
@KangOl added! Also, which is better |
|
Good question.
|
xmo-odoo
approved these changes
Jul 16, 2018
mart-e
force-pushed
the
saas-11.2-remove-dup-insert-missing-trans-mat
branch
2 times, most recently
from
dda0b6d
to
86d053b
Compare
Since 160d657, the translations must be unique on the source. When calling insert_missing on a field, the final step is to set the correct source on every translation to keep them synchronised. In case the translation looked like: id | lang | src | type | res_id | name ---------+-------+-----+-------+--------+------------------ 42 | fr_FR | KGM | model | 2 | product.uom,name 43 | fr_FR | kg | model | 2 | product.uom,name The final step will fail as violating the unicity constraint. Remove duplicated translations before making the update. It was chosen to keep the latest translation as it should be the most up to date (e.g. after an import creating duplicated translations). Add a non-regression test for previous change opw-1864123 Closes odoo#25787
mart-e
force-pushed
the
saas-11.2-remove-dup-insert-missing-trans-mat
branch
from
86d053b
to
2472bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 160d657, the translations must be unique on the source.
When calling insert_missing on a field, the final step is to set the correct source on every translation to keep them synchronised (
UPDATE ir_translation SET src=%(src)s).In case the translation looked like:
The final step will fail as violating the unicity constraint.
Remove duplicated translations before making the update.
opw-1866065