Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[ADD] l10n_fr_pos_cert : print hash on the bill, or print a message, if the server is unreachable. #26314
This PR is :
It adds the hash on the bill, in the point of sale, if the company is flagged as _is_accounting_unalterable by the module
Todo List @legalsylvain
Related extra works
Thanks for your review !
Hi @mart-e. Thanks for your review. I made some changes.
French governement Reference question n°34
Si un logiciel est assez ouvert pour permettre à un intégrateur de paramétrer l'inaltérabilité, la
Awaiting other remarks. Did you take a look on the time out possible trouble ? If the server is slow (pos.order creation > 7.5 second) , the warning message will be printed.
@flotho I am not familiar with the queue process from OCA so do not have an opinion but it is not something we can use in core anyway (could be discussed to integrate this upstream but that is a different topic). Instead I would investigate (e.g. using flamegraph) why it takes so much time in the first place.
Hi @mart-e , OCA queue was simply a proposal to make asynchron call of the picking validation during the pos.order create_from_ui process.
I hope that you would consider that the great work delivered by @legalsylvain won't be appreciated correctly by our customers if the delay to print the receipt change from mostly immediate to 5 to 9 seconds.
Anyway, thanks fro the time spent to read this comment
From what I tested:
There was a small bug:
And there is that weird stuff where odoo Class should support _super, but do not for some reason :D