New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_payroll_account: Salary rules accounting can be used in multicompany #26866

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gustavovalverde
Contributor

gustavovalverde commented Sep 10, 2018

…nies

Before this commit

  • Install a l10n_xx_hr_payroll which includes information of the rules (it always install in the main company: Company A in this use case).
  • Configure the accounting for the rules
  • Create Company B
  • Use the same salary rules for both companies, as l10n_xx_hr_payroll modules are not multicompany.

Behavior:

  • Company A accounts are shown in Company B salary rules.
  • If the accounts are changed in Company B rules, it also overrides Company A accounts, (which causes major confusions, and great mistakes if a payslip is run).
  • A salary rule with Company A set on company_id can still be seen through Company B. which causes that it can be mistakenly ran by a user in Company B, with the accounting of Company A.

After this commit:
Salary rules accounting can be used with multi-company

OPW 1847799
Fixes #23814

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@gustavovalverde

This comment has been minimized.

Contributor

gustavovalverde commented Sep 11, 2018

@rim-odoo this seems to be the simpler solution to allow a multi company behavior on the accounting, while using the same salary rule on other companies.

I'd like to have your feedback on this one.

@robodoo robodoo removed the CI 🤖 label Sep 24, 2018

@gustavovalverde

This comment has been minimized.

Contributor

gustavovalverde commented Sep 24, 2018

I've already tested this with our clients, we have a 5 multi-company payroll working under this scenario; an it fulfills the need.

Further PRs that I'll do will make the whole payroll easier to manage in multicompany environments; but at least this PR allows to use it with accounting; which is not possible right now.

cc: @tivisse @nim-odoo

@nim-odoo nim-odoo requested a review from tivisse Sep 25, 2018

@robodoo robodoo added the CI 🤖 label Sep 27, 2018

@tivisse tivisse assigned tivisse and unassigned tivisse Oct 17, 2018

@tivisse tivisse added HR and removed HR labels Nov 8, 2018

[FIX] hr_payroll_account: Allow salary rules to be used in multicompa…
…nies

Before this commit
- Install a **l10n_xx_hr_payroll** which includes information of the rules (it always install in the main company: **Company A** in this use case).
- Configure the accounting for the rules
- Create **Company B**
- Use the same salary rules for both companies, as **l10n_xx_hr_payroll** modules are not multicompany.

Behavior:
- **Company A** accounts are shown in **Company B** salary rules.
- If the accounts are changed in **Company B** rules, it also overrides **Company A** accounts, (which causes major confusions, and great mistakes if a payslip is run).
- A salary rule with **Company A** set on `company_id` can still be **seen** through Company B. which causes that it can be mistakenly _ran by a user in Company B_, with the _accounting of Company A_.

After this commit:
Salary rules accounting can be used with multi-company

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 8, 2018

@tivisse

This comment has been minimized.

Contributor

tivisse commented Nov 13, 2018

Hi @gustavovalverde

I think you're right on this one. This will be integrated into the same internal task to manage multi company in payroll (internal link: https://www.odoo.com/web#id=1873669&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720).

That way, we will introduce a complete multi-company integration in the same time.

Thanks for the feedback, and have a nice day,

Yannick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment