New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_slides: fix bs4 bugs #27131

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
3 participants
@seb-odoo
Contributor

seb-odoo commented Sep 20, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@seb-odoo seb-odoo added the RD label Sep 20, 2018

@seb-odoo seb-odoo requested a review from rdeodoo Sep 20, 2018

@rdeodoo

This comment has been minimized.

Show comment
Hide comment
@rdeodoo

rdeodoo Sep 20, 2018

Contributor

hi @qsm-odoo can you check this? (Check the diff with ?w=1 it will be easier to read)
UI looks fine, there is a last fix on iframe/canvas scrollbar to check with seb

Contributor

rdeodoo commented Sep 20, 2018

hi @qsm-odoo can you check this? (Check the diff with ?w=1 it will be easier to read)
UI looks fine, there is a last fix on iframe/canvas scrollbar to check with seb

@rdeodoo rdeodoo requested a review from qsm-odoo Sep 20, 2018

@seb-odoo

This comment has been minimized.

Show comment
Hide comment
@seb-odoo

seb-odoo Sep 21, 2018

Contributor

@qsm-odoo thank you for the review, I made the changes (and some other fixes). If you could quickly check again while I wait for green runbot... Thanks!

Contributor

seb-odoo commented Sep 21, 2018

@qsm-odoo thank you for the review, I made the changes (and some other fixes). If you could quickly check again while I wait for green runbot... Thanks!

seb-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 21, 2018

seb-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 21, 2018

@qsm-odoo

Seems good, one small change

@seb-odoo seb-odoo merged commit 0027544 into odoo:saas-11.5 Sep 25, 2018

@seb-odoo seb-odoo deleted the odoo-dev:saas-11.5-website-seb branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment