New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock: use merged moves in _action_done #27136

Closed
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
4 participants
@caburj
Contributor

caburj commented Sep 20, 2018

The _action_done executes _action_confirm to draft moves. The
_action_confirm merges similar moves and the merging basically
collects the information of similar moves and combines them to the
first move. The other moves are unlinked.

The calculation process of _action_done involves the original moves
(self) that can contain unlinked moves because of _action_confirm,
which can then result to error as per described in OPW.

This fix makes sure that the calculation process of _action_done skips
the unlinked moves.

OPW 1885053

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Sep 20, 2018

@C3POdoo C3POdoo added the OE label Sep 20, 2018

[FIX] stock: use merged moves in _action_done
The _action_done executes _action_confirm to draft moves. The
_action_confirm merges similar moves and the merging basically
collects the information of similar moves and combines them to the
first move. The other moves are unlinked.

The calculation process of _action_done involves the original moves
(self) that can contain unlinked moves because of _action_confirm,
which can then result to error as per described in OPW.

This fix makes sure that the calculation process of _action_done skips
the unlinked moves.

OPW 1885053

@simongoffin simongoffin self-requested a review Sep 24, 2018

@simongoffin

This comment has been minimized.

Show comment
Hide comment
@simongoffin

simongoffin Sep 24, 2018

Contributor

Hello @caburj

As we discussed about it the PR is not valid

Contributor

simongoffin commented Sep 24, 2018

Hello @caburj

As we discussed about it the PR is not valid

@robodoo robodoo added the closed 💔 label Sep 24, 2018

@caburj caburj deleted the odoo-dev:11.0-stock-fix-action-done-on-merged-moves-jcb branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment