Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] point_of_sale: align with backend fp mapping #27825

Closed
wants to merge 1 commit into from

Conversation

switch87
Copy link
Contributor

@switch87 switch87 commented Oct 16, 2018

The backend allows to map one source tax to various target taxes. The POS
diverged from this behaviour.

This commit alignes the behaviours and lets the point of sale handle mapping
to multiple taxes the same way the backend does.

backport of pr #26415 to 11.0
resolves ticket 1889884

Copy link
Contributor

@nim-odoo nim-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I agree this is necessary, that remains an improvement, not a bug. The POS has been evolving slower than the other modules for the last 4 years, and there are behaviors available in SO/Invoice which are not available in the POS. This is expected, and hopefully the gap will be filled for v13.

@pedrobaeza
Copy link
Collaborator

My 2 cents on this: there are a lot of localizations that need to map several taxes from one source tax, so if you don't put this patch, v11 POS won't be usable for that countries, so although an improvement, it's a needed improvement, and it won't modify any behavior, but add a needed one.

@switch87 switch87 force-pushed the 11.0-pos-fp-mapping-gpe branch 2 times, most recently from bb12859 to 4608715 Compare October 16, 2018 13:03
The backend allows to map one source tax to various target taxes. The POS
diverged from this behaviour.

This commit alignes the behaviours and lets the point of sale handle mapping
to multiple taxes the same way the backend does.

backport of pr  odoo#26415 to 11.0

[IMP] account: add fp2m unit test

[ADD] point_of_sale: js test for 2m fp
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 17, 2018
@mart-e
Copy link
Contributor

mart-e commented Oct 19, 2018

I am not in favour of backporting this as well. As said on the ticket, it was not supported so far.
I agree it is a feature that is lacking so far but we do not add new features in stable version, don't forget you always may break somebody's workflow 😉

@switch87
Copy link
Contributor Author

oke, I close this pr 👍

@switch87 switch87 closed this Oct 19, 2018
@pedrobaeza
Copy link
Collaborator

OK, you're right.

Then I suppose this should be added as extra module for versions lower than 12.0 for those that need them. We did something similar with pricelists in the module https://github.com/OCA/pos/tree/10.0/pos_pricelist.

@nim-odoo nim-odoo deleted the 11.0-pos-fp-mapping-gpe branch October 19, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants