Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master accounting onboarding issues eco #28131

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@eco-odoo
Copy link
Contributor

eco-odoo commented Oct 25, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Oct 25, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 25, 2018

@eco-odoo eco-odoo force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Nov 5, 2018

@robodoo robodoo added the CI 🤖 label Nov 5, 2018

@eco-odoo eco-odoo force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Nov 5, 2018

@robodoo robodoo removed the CI 🤖 label Nov 5, 2018

@eco-odoo eco-odoo force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch 2 times, most recently Nov 5, 2018

@robodoo robodoo added the CI 🤖 label Nov 5, 2018

@eco-odoo eco-odoo force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Nov 6, 2018

@robodoo robodoo removed the CI 🤖 label Nov 6, 2018

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch 2 times, most recently Nov 22, 2018

@robodoo robodoo added the CI 🤖 label Nov 22, 2018

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Nov 23, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 23, 2018

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Nov 28, 2018

@robodoo robodoo removed the CI 🤖 label Nov 28, 2018

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch 2 times, most recently Nov 28, 2018

@robodoo robodoo added the CI 🤖 label Nov 28, 2018

@odoo odoo deleted a comment from robodoo Nov 28, 2018

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Nov 28, 2018

I'm sorry, @william-andre. I'm afraid I can't do that.

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Dec 13, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 13, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 22, 2019

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Feb 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 25, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Mar 5, 2019

needs a rework of the commits history

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch Mar 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch to 5459f6d Mar 8, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 8, 2019

Show resolved Hide resolved addons/account/models/account_journal_dashboard.py Outdated
Show resolved Hide resolved addons/account/models/account_journal_dashboard.py Outdated
Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated
Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated
Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated
Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated
Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated

new_journal_name = fields.Char(default=lambda self:self.linked_journal_id.name, inverse='set_linked_journal_id', required=True, help='Will be used to name the Journal related to this bank account')
linked_journal_id = fields.Many2one(string="Journal", comodel_name='account.journal', inverse='set_linked_journal_id', compute="compute_linked_journal_id", default=lambda self:self.default_linked_journal_id())
new_journal_code = fields.Char(string="Code", required=True, default=lambda self:self._compute_joural_code())

This comment has been minimized.

@oco-odoo

oco-odoo Mar 15, 2019

Contributor

journal (in the compute function's name)

Moreover, do we really need the default here ? Isn't the onchange called anyway ?

new_journal_code = fields.Char(string="Code", required=True, default=lambda self: self.env['account.journal'].get_next_bank_cash_default_code('bank', self.env['res.company']._company_default_get('account.journal').id))

new_journal_name = fields.Char(default=lambda self:self.linked_journal_id.name, inverse='set_linked_journal_id', required=True, help='Will be used to name the Journal related to this bank account')
linked_journal_id = fields.Many2one(string="Journal", comodel_name='account.journal', inverse='set_linked_journal_id', compute="compute_linked_journal_id", default=lambda self:self.default_linked_journal_id())

This comment has been minimized.

@oco-odoo

oco-odoo Mar 15, 2019

Contributor

compute + default? Oo Can't we remove the default (to check)?

This comment has been minimized.

@william-andre

william-andre Mar 18, 2019

Contributor

The field is set to False without the default, not sure of the use of compute though

This comment has been minimized.

@william-andre

william-andre Mar 25, 2019

Contributor

I corrected it

Show resolved Hide resolved addons/account/wizard/setup_wizards.py Outdated

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch from 5459f6d to d787345 Mar 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 18, 2019

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch from d787345 to c07229e Mar 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 20, 2019

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch from c07229e to 5b16283 Mar 21, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 21, 2019

eco-odoo and others added some commits Oct 23, 2018

[IMP] account: improve dashboard design
Replace "Balance in General Ledger" by "Balance in GL" or simply "Balance" when both balances are equal.
Rename Import Bills > Upload bills.
Remove space between labels and values.

Task: 1893104

@william-andre william-andre force-pushed the odoo-dev:master-accounting-onboarding-issues-eco branch from 5b16283 to e015156 Mar 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.