Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][IMP] sale,base,account : improve sales onboarding #28254

Closed
wants to merge 3 commits into from

Conversation

gla-odoo
Copy link
Contributor

@gla-odoo gla-odoo commented Oct 29, 2018

Purpose : Ease navigation in default screens of Sales app to better onboard new
users and fix various issues in the views.

  • onboarding tour : fix "quotations" filter and tooltip appearance

  • config bar :
    -remove "Default incoterm" field in "company info" form and move it in
    "invoicing" settings.

    • improve "document layout" form design, set "paper format" as required
      field and add a "preview" button
    • rename FieldReportLayout "Preview" link and put standard report layout (the default one in odoo) as first image
    • fix small design issue in widget
    • "done" button design
  • customer form :

    • improve address type tooltip
    • various changes in "accounting" and "sales & purchases" tabs (stat button, fields reorganizing)
  • product form : fix "re-invoice policy" field hazardous hiding behavior and improve field appearance

  • customer portal :

    • reorganize fields in "customer details" view
    • minor changes in "quotation" view
  • Correct "sales order" model description

This merge is related to task ID 1892500 .

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Oct 29, 2018
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 30, 2018
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Nov 6, 2018
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Nov 6, 2018
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Nov 7, 2018
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Nov 7, 2018
Copy link
Contributor

@tde-banana-odoo tde-banana-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech review

addons/account/views/partner_view.xml Show resolved Hide resolved
@@ -524,6 +524,18 @@
</div>
</div>
</div>
<div class="col-12 col-lg-6 o_setting_box">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is an indentation issue (one tab). Could you check ?

addons/sale/data/mail_data.xml Outdated Show resolved Hide resolved
@@ -1,6 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="report_layout_standard" model="report.layout">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an unnecessary diff ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the idea is to get the standard layout (selected by default) appear first in the widget

odoo/addons/test_impex/tests/contacts.json Show resolved Hide resolved
Small changes to the customer portal : form input reorderings,
relabelling, removal of the draft quotation warning.
Various ux improvements in the product and contact form views :

Contact :
- hide/reveal fields according to customer/supplier status and
reorganize
- fields moved to stat buttons
- addresses : tooltip and relabelling

Product:
- Fix re-expense policy (dis-)appearance and fields style
Improve various design elements in sales onboarding and config bar :

Onboarding :
- tooltip and done button

Company info:
- Move the incoterm field from company view to account settings.

Document layout:
- layout widget relabelling and reorganizing
- paper format as required
- added a Preview button

Payment methods and sample quotation :
- Style and relabelling
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Nov 16, 2018
@tde-banana-odoo tde-banana-odoo changed the title [IMP] sale,base,account : sales onboarding [MERGE][IMP] sale,base,account : improve sales onboarding Nov 19, 2018
@tde-banana-odoo
Copy link
Contributor

@robodoo r+

robodoo added a commit that referenced this pull request Nov 19, 2018
Purpose : Ease navigation in default screens of Sales app to better onboard new
users and fix various issues in the views.

- onboarding tour : fix "quotations" filter and tooltip appearance
- config bar :
  -remove "Default incoterm" field in "company info" form and move it in
  "invoicing" settings.
  - improve "document layout" form design, set "paper format" as required
  field and add a "preview" button
  - rename FieldReportLayout "Preview" link and put standard report layout (the default one in odoo) as first image
  - fix small design issue in widget
  - "done" button design

- customer form :
  - improve address type tooltip
  - various changes in "accounting" and "sales & purchases" tabs (stat button, fields reorganizing)

- product form : fix "re-invoice policy" field hazardous hiding behavior and improve field appearance
- customer portal :
  - reorganize fields in "customer details" view
  - minor changes in "quotation" view

- Correct "sales order" model description

This merge is related to task ID 1892500 .

closes #28254
@robodoo
Copy link
Contributor

robodoo commented Nov 19, 2018

Merged, thanks!

@robodoo robodoo closed this Nov 19, 2018
@gla-odoo gla-odoo deleted the master-sales-onboarding-gla branch February 22, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants