Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: forbid locking the fiscal year or period in case there is an open POS session into it #28257

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@oco-odoo
Copy link
Contributor

oco-odoo commented Oct 29, 2018

Without that, it is impossible to close these sessions, as the lock date forbids posting accounting entries for them.

@qdp-odoo
Copy link
Contributor

qdp-odoo left a comment

almost ok

Show resolved Hide resolved addons/point_of_sale/models/res_company.py Outdated

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch Nov 26, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 26, 2018

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch Jan 11, 2019

@robodoo robodoo removed the CI 🤖 label Jan 11, 2019

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch Jan 11, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Feb 13, 2019

needs a rebase with master and a rebuild to green the runbot, otherwise it's ready to be approved

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch 2 times, most recently Feb 19, 2019

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch 2 times, most recently Mar 4, 2019

@robodoo robodoo added the CI 🤖 label Mar 4, 2019

@oco-odoo oco-odoo force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch to 0273884 Mar 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

[IMP] point_of_sale: accounting lock dates and POS sessions
Forbid locking the fiscal year or period in case there is an open POS session into it. Without that, it will be impossible to close these sessions, as the lock date will not allow posting accounting entries for them.

Also forbid to create a session before lock date, as it would be impossible to close.

@csnauwaert csnauwaert force-pushed the odoo-dev:master-account-lock-pos-imp-oco branch from 0273884 to 6305404 Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@csnauwaert csnauwaert requested a review from qdp-odoo Mar 18, 2019

@csnauwaert

This comment has been minimized.

Copy link
Contributor

csnauwaert commented Mar 18, 2019

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[IMP] point_of_sale: accounting lock dates and POS sessions
Forbid locking the fiscal year or period in case there is an open POS session into it. Without that, it will be impossible to close these sessions, as the lock date will not allow posting accounting entries for them.

Also forbid to create a session before lock date, as it would be impossible to close.

closes #28257

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.