New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master update jquery #28457

Open
wants to merge 80 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@VincentSchippefilt
Contributor

VincentSchippefilt commented Nov 7, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Nov 7, 2018

@@ -488,7 +488,7 @@ var ActionManager = Widget.extend({
});
this.controllers[controllerID] = controller;
action.controllerID = controllerID;
return this._executeAction(action, options).done(function () {

This comment has been minimized.

@aab-odoo

aab-odoo Nov 7, 2018

Contributor

be careful with this

This comment has been minimized.

@VincentSchippefilt

VincentSchippefilt Nov 8, 2018

Contributor

yes, we have updated, thanks

var r1 = dp.add(def1);
var dp1 = dp.add(prom1).then(() => assert.catch('should not go here'))

This comment has been minimized.

@aab-odoo

aab-odoo Nov 7, 2018

Contributor

.step

This comment has been minimized.

@VincentSchippefilt
return this._super.apply(this, arguments);
return Promise.all([this._super.apply(this, arguments), renderPromise]);

This comment has been minimized.

@aab-odoo

aab-odoo Nov 7, 2018

Contributor

you change the behavior here

This comment has been minimized.

@VincentSchippefilt

VincentSchippefilt Nov 8, 2018

Contributor

indeed. We will re-optimize if needed.

@C3POdoo C3POdoo added the RD label Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment