New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: enable composer after message sent #28506

Closed
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
2 participants
@nle-odoo
Contributor

nle-odoo commented Nov 8, 2018

c5dc0b2 disabled send button on composer sent.

But this is only needed for chatter composer, other composers directly
send the message and are not refreshed asynchronously.

So for other composer, the send button worked one time but then was
disabled and the only way to sent was ENTER (on basic composer) or
CTRL+ENTER (on extended composer).

With this fix, disabling the button is done only for chatter composer.

11.0 backport of 12.0 #28474

issue found when checking opw-1904029

@robodoo robodoo added the seen 🙂 label Nov 8, 2018

@nle-odoo nle-odoo added OE and removed seen 🙂 labels Nov 8, 2018

nle-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 8, 2018

[FIX] mail: enable composer after message sent
c5dc0b2 disabled send button on composer sent.

But this is only needed for chatter composer, other composers directly
send the message and are not refreshed asynchronously.

So for other composer, the send button worked one time but then was
disabled and the only way to sent was ENTER (on basic composer) or
CTRL+ENTER (on extended composer).

With this fix, disabling the button is done only for chatter composer.
Also the behavior of not clearing the message if there was an error is
introduced back.

Without change in code, added test fails with:
 "Message with failed delivery is not removed" (result: "")
 "Send button should be enabled after failure" (result: true)

11.0 backport of 12.0 odoo#28474

issue found when checking opw-1904029
closes odoo#28506

nle-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 8, 2018

[FIX] mail: enable composer after message sent
c5dc0b2 disabled send button on composer sent.

But this is only needed for chatter composer, other composers directly
send the message and are not refreshed asynchronously.

So for other composer, the send button worked one time but then was
disabled and the only way to sent was ENTER (on basic composer) or
CTRL+ENTER (on extended composer).

With this fix, disabling the button is done only for chatter composer.

11.0 backport of 12.0 odoo#28474

issue found when checking opw-1904029
closes odoo#28506
[FIX] mail: enable composer after message sent
c5dc0b2 disabled send button on composer sent.

But this is only needed for chatter composer, other composers directly
send the message and are not refreshed asynchronously.

So for other composer, the send button worked one time but then was
disabled and the only way to sent was ENTER (on basic composer) or
CTRL+ENTER (on extended composer).

With this fix, disabling the button is done only for chatter composer.

11.0 backport of 12.0 #28474

issue found when checking opw-1904029
closes #28506

@robodoo robodoo added the CI 🤖 label Nov 8, 2018

@nle-odoo

This comment has been minimized.

Contributor

nle-odoo commented Nov 9, 2018

robodoo r+

@robodoo robodoo added the r+ 👌 label Nov 9, 2018

robodoo pushed a commit that referenced this pull request Nov 9, 2018

[FIX] mail: enable composer after message sent
c5dc0b2 disabled send button on composer sent.

But this is only needed for chatter composer, other composers directly
send the message and are not refreshed asynchronously.

So for other composer, the send button worked one time but then was
disabled and the only way to sent was ENTER (on basic composer) or
CTRL+ENTER (on extended composer).

With this fix, disabling the button is done only for chatter composer.

11.0 backport of 12.0 #28474

issue found when checking opw-1904029
closes #28506
@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 9, 2018

Merged, thanks!

@robodoo robodoo closed this Nov 9, 2018

@nle-odoo nle-odoo deleted the odoo-dev:11.0-staging-nle branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment