New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] test_*: assure demo data is demo data #28511

Open
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
2 participants
@mreficent
Contributor

mreficent commented Nov 8, 2018

Description of the issue/feature this PR addresses:

There are few modules that have demo data as normal data, and thus it's a problem if you want to install the modules without installing their demo data.

Current behavior before PR: Some demo data is normal data.

Desired behavior after PR is merged: All demo data is demo data.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@mreficent

This comment has been minimized.

Contributor

mreficent commented Nov 14, 2018

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Nov 14, 2018

Test modules are not intended to be used on production server. Therefore having real data does not seem a big issue to me. What is really the purpose of this branch ?

@mreficent

This comment has been minimized.

Contributor

mreficent commented Nov 14, 2018

I know they are not intended for production, no issues here, but I just like things correctly put where they should be. Real data is real data and demo data is demo data :S

I found this when I installed all modules into a database without demo data to do an analysis.

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Nov 14, 2018

I think "demo data" of test modules are real data used in tests. I would vote for renaming to data and not using demo data. If you install the test module you will likely need some data to run the tests and those are not demo data. I did not look into details about their use in tests, maybe I am wrong.

@mreficent

This comment has been minimized.

Contributor

mreficent commented Nov 14, 2018

If you install the test module you will likely need some data to run the tests and those are not demo data.

Not necessarily. Perhaps these test modules have the capacity to create new data from the models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment