New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] wording #28517

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@fhe-odoo
Contributor

fhe-odoo commented Nov 8, 2018

I think expiration it's much clearer.

@@ -141,7 +141,7 @@ def _get_payment_type(self):
('cancel', 'Cancelled'),
], string='Status', readonly=True, copy=False, index=True, track_visibility='onchange', track_sequence=3, default='draft')
date_order = fields.Datetime(string='Order Date', required=True, readonly=True, index=True, states={'draft': [('readonly', False)], 'sent': [('readonly', False)]}, copy=False, default=fields.Datetime.now)
validity_date = fields.Date(string='Validity', readonly=True, copy=False, states={'draft': [('readonly', False)], 'sent': [('readonly', False)]},
validity_date = fields.Date(string='Expiration', readonly=True, copy=False, states={'draft': [('readonly', False)], 'sent': [('readonly', False)]},
help="Validity date of the quotation, after this date, the customer won't be able to validate the quotation online.", default=_default_validity_date)

This comment has been minimized.

@mart-e

mart-e Nov 9, 2018

Contributor

should "Validity date of the quotation" stay or be adapted as well?

This comment has been minimized.

@fhe-odoo

fhe-odoo Nov 9, 2018

Contributor

Yes indeed, it should be adapted.

[IMP] sale: rephrase label
Expiration is clearer than validity

@robodoo robodoo removed the CI 🤖 label Nov 12, 2018

@mart-e

This comment has been minimized.

Contributor

mart-e commented Nov 12, 2018

robodoo r+
robodoo retry
robodoo retry !

robodoo pushed a commit that referenced this pull request Nov 12, 2018

[IMP] sale: rephrase label
Expiration is clearer than validity

closes #28517
@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 12, 2018

Staging failed: ci/runbot on a52be7a97c30dfd5e0b0c1b00f5189a02d79879d (view more at http://runbot.odoo.com/runbot/build/396954)

@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 12, 2018

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/397091)

robodoo pushed a commit that referenced this pull request Nov 12, 2018

[IMP] sale: rephrase label
Expiration is clearer than validity

closes #28517

@robodoo robodoo added merging 👷 and removed merging 👷 labels Nov 12, 2018

@robodoo robodoo added the merged 🎉 label Nov 12, 2018

@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 12, 2018

Merged, thanks!

@robodoo robodoo closed this Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment