New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE] base, web: split the documents features from ir.attachment #28563

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@ThanhDodeurOdoo
Contributor

ThanhDodeurOdoo commented Nov 12, 2018

The first implementation of documents was based on ir_attachment,
adding fields only useful when the attachment was a document.

This task splits documents in a new model called documents.documents,
and clean the logic accordingly.

This task also recovers the "attachment" action button, to list attachments on a model
without chatter.

related to: odoo/enterprise#3048
task: #1908896

@ThanhDodeurOdoo ThanhDodeurOdoo requested a review from antonylesuisse Nov 12, 2018

@robodoo robodoo added the CI 🤖 label Nov 12, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo requested a review from Xavier-Do Nov 12, 2018

@C3POdoo C3POdoo added the RD label Nov 13, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo requested a review from alexkuhn Nov 13, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 13, 2018

Show resolved Hide resolved addons/mail/static/src/js/document_viewer.js Outdated
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml Outdated
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml Outdated
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml Outdated
Show resolved Hide resolved addons/mail/static/src/xml/thread.xml
Show resolved Hide resolved addons/mail/static/tests/document_viewer_tests.js Outdated

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 14, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from ff157a6 to 1e7ecd5 Nov 19, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 19, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from 1e7ecd5 to 1f29e8e Nov 20, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 20, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from 1f29e8e to 85663e0 Nov 20, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 20, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from 85663e0 to 704e563 Nov 21, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 21, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo changed the title from Master documents refactor tso to [REF] documents: splits the documents features from ir attachment Nov 22, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from 704e563 to 4f5ab3e Nov 22, 2018

ThanhDodeurOdoo added a commit to odoo-dev/odoo that referenced this pull request Nov 22, 2018

[REF] documents: splits the documents feature from ir attachment
moved the field 'active', 'res_model_name' and 'thumbnail' from
ir.attachment to enterprise's documents.document.

moved the pdf split feature to enterprise's Documents module

closes: odoo#28563
task: #1908896

@robodoo robodoo removed the CI 🤖 label Nov 22, 2018

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from 4f5ab3e to b789bd0 Nov 22, 2018

ThanhDodeurOdoo added a commit to odoo-dev/odoo that referenced this pull request Nov 22, 2018

[REF] documents: splits the documents feature from ir attachment
moved the field 'active', 'res_model_name' and 'thumbnail' from
ir.attachment to enterprise's documents.document.

moved the pdf split feature to enterprise's Documents module

closes: odoo#28563
task: #1908896

Xavier-Do added a commit to odoo-dev/odoo that referenced this pull request Dec 6, 2018

[REF] base, *: refactor binary_content
*: tools, web, website, website_forum, mail, im_livechat

This commit refactors ir_http to make it more readable
and flexible.

Move the resize function of web/image to odoo.tools

Co-authored-by: XavierDo <xdo@odoo.com>
Co-authored-by: Antony Lesuisse <al@openerp.com>

closes: odoo#28563
task: #1908896

@Xavier-Do Xavier-Do force-pushed the odoo-dev:master-documents-refactor-tso branch from ef7c5d7 to a0322e7 Dec 6, 2018

@Xavier-Do

This comment has been minimized.

Contributor

Xavier-Do commented Dec 6, 2018

robodoo r+ hopefully enterprise will be green...

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

Linked pull request(s) odoo/enterprise#3048 not ready. Linked PRs are not staged until all of them are ready.

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

Because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@odony odony changed the title from [MERGE] base, web: splits the documents features from ir.attachment to [MERGE] base, web: split the documents features from ir.attachment Dec 6, 2018

@odony

This comment has been minimized.

Contributor

odony commented Dec 6, 2018

@robodoo rebase-merge

@Xavier-Do

This comment has been minimized.

Contributor

Xavier-Do commented Dec 6, 2018

Merci. Il ne faut pas le faire pour la pr enterprise aussi?

ThanhDodeurOdoo added some commits Nov 7, 2018

[REF] base, mail: splits the documents feature from ir attachment
Moved the field 'active', 'res_model_name' and 'thumbnail' from
ir.attachment to enterprise's documents.document.

Moved the pdf split feature to enterprise's Documents module.

task: #1908896
[REF] base, *: refactor binary_content
*: tools, web, website, website_forum, mail, im_livechat

This commit refactors ir_http to make it more readable
and flexible.

Move the resize function of web/image to odoo.tools

Co-authored-by: XavierDo <xdo@odoo.com>
Co-authored-by: Antony Lesuisse <al@openerp.com>

closes: #28563
task: #1908896
Revert "[FIX] document: JS feature disabled"
This reverts commit 1dbb555

Bring the sidebar attachment dropdown feature back.

This feature was removed due to be considered as useless,
but since some models can have attachement without a mail_thread,
this feature is still necessary.

task: #1908896
[REF] document, attachment_indexation: renames the module document
This commit renames the module document into attachment_indexation
to provide a more descriptive name and avoid confusion with
enterprise's documents module.

task: #1908896
[REF] attachment_indexation, *: replace old references to document
*: hr_recruitment, web, website_sale_digital

This commit replaces the references to 'document' by 'attachment_indexation'
following the rename of the module.

Task #1908896

@ThanhDodeurOdoo ThanhDodeurOdoo force-pushed the odoo-dev:master-documents-refactor-tso branch from a0322e7 to 54ac362 Dec 6, 2018

@ThanhDodeurOdoo

This comment has been minimized.

Contributor

ThanhDodeurOdoo commented Dec 6, 2018

I force pushed a freshly rebased version to 'fix' the enterprise branch that was red due to missing community commits.

@robodoo robodoo added the CI 🤖 label Dec 6, 2018

@alexkuhn

This comment has been minimized.

Contributor

alexkuhn commented Dec 6, 2018

robodoo r+

@robodoo robodoo added the r+ 👌 label Dec 6, 2018

robodoo pushed a commit that referenced this pull request Dec 7, 2018

[REF] base, *: refactor binary_content
*: tools, web, website, website_forum, mail, im_livechat

This commit refactors ir_http to make it more readable
and flexible.

Move the resize function of web/image to odoo.tools

Co-authored-by: XavierDo <xdo@odoo.com>
Co-authored-by: Antony Lesuisse <al@openerp.com>

closes: #28563
task: #1908896

robodoo added a commit that referenced this pull request Dec 7, 2018

[MERGE] base, web: split the documents features from ir.attachment
The first implementation of `documents` was based on `ir_attachment`,
adding fields only useful when the attachment was a document.

This task splits documents in a new model called documents.documents,
and clean the logic accordingly.

This task also recovers the "attachment" action button, to list attachments on a model
without chatter.

related to: odoo/enterprise#3048
task: #1908896

closes #28563
@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 7, 2018

Merged, thanks!

@robodoo robodoo closed this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment