New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product: clean forms and improve archiving #28633

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@gla-odoo

gla-odoo commented Nov 13, 2018

Several last cleaning in the product and product variant form :

  • various labelling and design improvements
  • sales, purchased and manufactured stat button (number of sales was
    incorrect and click will now open normal sales analysis)
  • now archiving related product.template if there is only one active product.product

Task-1880039 closes #28633

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Nov 14, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from ca8e0ba to 929eb54 Nov 16, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 16, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 929eb54 to 93e2bbc Nov 19, 2018

@robodoo robodoo removed the CI 🤖 label Nov 19, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch 4 times, most recently from 2086f77 to 224cc0a Nov 19, 2018

@robodoo robodoo added the CI 🤖 label Nov 19, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 224cc0a to 9da84ac Nov 20, 2018

@robodoo robodoo removed the CI 🤖 label Nov 20, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 9da84ac to 72e5eb2 Nov 20, 2018

@robodoo robodoo added the CI 🤖 label Nov 20, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 72e5eb2 to 423e215 Nov 27, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 27, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 423e215 to 23d7f56 Nov 27, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 27, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 23d7f56 to e58fa4a Nov 27, 2018

@robodoo robodoo removed the CI 🤖 label Nov 27, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from e58fa4a to b9e714e Nov 27, 2018

@robodoo robodoo added the CI 🤖 label Nov 27, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from b9e714e to 0dcea4a Dec 3, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 3, 2018

@robodoo robodoo added the CI 🤖 label Dec 5, 2018

@gla-odoo gla-odoo force-pushed the odoo-dev:master-product-form-usability-gla branch from 23cda48 to bf8e538 Dec 6, 2018

gla-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 6, 2018

[IMP] product: clean forms and improve archiving
Several last cleaning in the product and product variant form :
- various labelling and design improvements
- sales, purchased and manufactured stat button (number of sales was
incorrect and click will now open normal sales analysis)
- now archiving related product.template if there is only one active product.product

Task-1880039  closes odoo#28633

@robodoo robodoo removed the CI 🤖 label Dec 6, 2018

@gla-odoo gla-odoo changed the title from [FIX] product form usability: cleaning product/product variant forms to [IMP] product: clean forms and improve archiving Dec 6, 2018

@jem-odoo

This comment has been minimized.

Contributor

jem-odoo commented Dec 6, 2018

LGTM !
@robodoo r+ please !

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

Linked pull request(s) odoo/enterprise#3069 not ready. Linked PRs are not staged until all of them are ready.

[IMP] product: clean forms and improve archiving
Several last cleaning in the product and product variant form :
- various labelling and design improvements
- sales, purchased and manufactured stat button (number of sales was
incorrect and click will now open normal sales analysis)
- now archiving related product.template if there is only one active product.product

Task-1880039  closes #28633

@KangOl KangOl force-pushed the odoo-dev:master-product-form-usability-gla branch from bf8e538 to 6a13b56 Dec 6, 2018

@robodoo robodoo added CI 🤖 and removed r+ 👌 CI 🤖 labels Dec 6, 2018

@KangOl

This comment has been minimized.

Contributor

KangOl commented Dec 6, 2018

@robodoo robodoo added the r+ 👌 label Dec 6, 2018

@KangOl

This comment has been minimized.

Contributor

KangOl commented Dec 6, 2018

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

I'm sorry, @KangOl. This PR is already reviewed, reviewing it again is useless.

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 6, 2018

@robodoo retry

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

I'm sorry, @tde-banana-odoo. Retry makes no sense when the PR is not in error.

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 6, 2018

@robodoo robodoo removed the r+ 👌 label Dec 6, 2018

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 6, 2018

@robodoo robodoo added the r+ 👌 label Dec 6, 2018

robodoo pushed a commit that referenced this pull request Dec 6, 2018

[IMP] product: clean forms and improve archiving
Several last cleaning in the product and product variant form :
- various labelling and design improvements
- sales, purchased and manufactured stat button (number of sales was
incorrect and click will now open normal sales analysis)
- now archiving related product.template if there is only one active product.product

Task-1880039  closes #28633
@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 6, 2018

Merged, thanks!

@robodoo robodoo closed this Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment