New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] report: support for wkhtmltopdf 0.12.5 #28864

Closed
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
4 participants
@beledouxdenis
Contributor

beledouxdenis commented Nov 21, 2018

This revision brings the compatibility for our reports
using wkhtmltopdf 0.12.5.

Up to now,
the supported wkhtmltopdf version was 0.12.1.

The goal of this revision is to add the compatibility
to wkhtmltopdf 0.12.5,
while keeping the same exact rendering than in 0.12.1.

There is a behavior change with the --dpi parameter,
which no longer has a "zoom" level effect as it did with 0.12.1.

To deal with it, we pass the --zoom parameter when
the detected version installed of wkhtmltopdf is after 0.12.2,
with a ratio 96:dpi. 96 being the default dpi of wkhtmltopdf.

This trick allows to render the reports with the exact same
zoom level, whatever the dpi value configured in the reports paperformat.
(at least with dpi values up to 149, after 150, included,
the dpi parameter with wkhtmltopdf 0.12.1 as a weird behavior,
it no longer zoom out)

opw-1907346

@beledouxdenis beledouxdenis requested review from sle-odoo and odony Nov 21, 2018

[FIX] report: support for wkhtmltopdf 0.12.5
This revision brings the compatibility for our reports
using wkhtmltopdf 0.12.5.

Up to now,
the supported wkhtmltopdf version was 0.12.1.

The goal of this revision is to add the compatibility
to wkhtmltopdf 0.12.5,
while keeping the same exact rendering than in 0.12.1.

There is a behavior change with the `--dpi` parameter,
which no longer has a "zoom" level effect as it did with 0.12.1.

To deal with it, we pass the `--zoom` parameter when
the detected version installed of wkhtmltopdf is after 0.12.2,
with a ratio 96:dpi. 96 being the default dpi of wkhtmltopdf.

This trick allows to render the reports with the exact same
zoom level, whatever the dpi value configured in the reports paperformat.
(at least with dpi values up to 149, after 150, included,
the dpi parameter with wkhtmltopdf 0.12.1 as a weird behavior,
it no longer zoom out)

opw-1907346

@beledouxdenis beledouxdenis force-pushed the odoo-dev:10.0-wkhtmltopdf-0.12.5-dle branch from 4465471 to 9480dce Nov 21, 2018

@C3POdoo C3POdoo added the OE label Nov 21, 2018

@KangOl

KangOl approved these changes Nov 21, 2018

LGTM

@guewen guewen referenced this pull request Nov 21, 2018

Open

Wkhtmltopdf 0.12.5.1 #62

@beledouxdenis

This comment has been minimized.

Contributor

beledouxdenis commented Nov 22, 2018

robodoo pushed a commit that referenced this pull request Nov 22, 2018

[FIX] report: support for wkhtmltopdf 0.12.5
This revision brings the compatibility for our reports
using wkhtmltopdf 0.12.5.

Up to now,
the supported wkhtmltopdf version was 0.12.1.

The goal of this revision is to add the compatibility
to wkhtmltopdf 0.12.5,
while keeping the same exact rendering than in 0.12.1.

There is a behavior change with the `--dpi` parameter,
which no longer has a "zoom" level effect as it did with 0.12.1.

To deal with it, we pass the `--zoom` parameter when
the detected version installed of wkhtmltopdf is after 0.12.2,
with a ratio 96:dpi. 96 being the default dpi of wkhtmltopdf.

This trick allows to render the reports with the exact same
zoom level, whatever the dpi value configured in the reports paperformat.
(at least with dpi values up to 149, after 150, included,
the dpi parameter with wkhtmltopdf 0.12.1 as a weird behavior,
it no longer zoom out)

opw-1907346

closes #28864
@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 22, 2018

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/402774)

@beledouxdenis

This comment has been minimized.

Contributor

beledouxdenis commented Nov 22, 2018

@robodoo retry

@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 22, 2018

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/402803)

@beledouxdenis

This comment has been minimized.

Contributor

beledouxdenis commented Nov 22, 2018

@robodoo retry

@robodoo robodoo added CI 🤖 and removed error 🙅 labels Nov 22, 2018

@robodoo

This comment has been minimized.

Contributor

robodoo commented Nov 22, 2018

Merged, thanks!

@robodoo robodoo closed this Nov 22, 2018

@odony odony deleted the odoo-dev:10.0-wkhtmltopdf-0.12.5-dle branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment