New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] web: mobile kanban tabs UX #29024

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@res-odoo
Copy link
Contributor

res-odoo commented Nov 26, 2018

This merge change the mobile kanban tabs UX by allowing to scroll
through them and go directly from a column A to B. It also improve the
readability independently of the title's length.

This behavior is heavily inspired by Material Design.

See: https://material.io/design/components/tabs.html

It's also an opportunity to refactor the mobile kanban renderer code to make it
more robust and readable.

Task: 1893168

@res-odoo res-odoo requested a review from adr-odoo Nov 26, 2018

@robodoo robodoo added the seen 🙂 label Nov 26, 2018

@C3POdoo C3POdoo added the RD label Nov 26, 2018

@robodoo robodoo added the CI 🤖 label Nov 26, 2018

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Nov 27, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 27, 2018

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Dec 21, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 21, 2018

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Dec 21, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 21, 2018

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Jan 15, 2019

@robodoo robodoo removed the CI 🤖 label Jan 15, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Jan 15, 2019

@robodoo robodoo added the CI 🤖 label Jan 15, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 4, 2019

@robodoo robodoo removed the CI 🤖 label Feb 4, 2019

@res-odoo res-odoo requested a review from pparidans Feb 4, 2019

@robodoo robodoo added the CI 🤖 label Feb 4, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 4, 2019

@robodoo robodoo removed the CI 🤖 label Feb 4, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 4, 2019

@robodoo robodoo added the CI 🤖 label Feb 4, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 5, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 6, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch 3 times, most recently from 0e7d9fe to c60f331 Feb 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 13, 2019

@res-odoo res-odoo force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch 5 times, most recently from dfcd8dc to 096b7ea Feb 13, 2019

@robodoo robodoo added the CI 🤖 label Feb 13, 2019

res-odoo added some commits Feb 11, 2019

[FIX] web: error on mobile when kanban groupedBy change
Sometimes when the groupedBy view is changed the index of the current
active column overflow the kanban tabs length.

In this commit this effect is avoided by resetting the active
kanban column to the first one when the groupedBy is changed.

Task: 1893168
[FIX] web: column data not loaded on mobile kanban view
This commit apply those changes:
 - Avoid overflow widgets array by checking its boundaries when the user swipes
   on the kanban column.
 - Extract the success callback update layout to avoid duplicated code.

Task: 1893168
[REF] web: cleanup the layout update for the mobile kanban view
The goal of this refactoring is mainly to improve the code readability
of the layout update in the mobile kanban renderer by focusing on each
parts separetaly:
 * mark current column as the active one.
 * compute the title tabs' position.
 * compute the content column's position.

Task: 1893168
[IMP] web: mobile kanban tabs UX
The mobile kanban title tabs required to move from column to column
1-by-1 to go from the first to the last column. Focusing everytime to
only the active column has ugly side effects when the titles are long
(eg. text overlapping).

This commit change the mobile kanban tabs UX by allowing to scroll
through them and go directly from a column A to B. It also improve the
readability independently of the title's length.

This behavior is heavily inspired by Material Design.

See: https://material.io/design/components/tabs.html

Task: 1893168

@pparidans pparidans force-pushed the odoo-dev:master-kanban-tab-mobile-text-res branch from 096b7ea to 61a9f17 Feb 14, 2019

@robodoo robodoo removed the CI 🤖 label Feb 14, 2019

@pparidans pparidans changed the title [IMP] web: Made Kanban Mobile Tabs more closer to Material Design spec [IMP] web: mobile kanban tabs UX Feb 14, 2019

@pparidans

This comment has been minimized.

Copy link
Contributor

pparidans commented Feb 14, 2019

@robodoo robodoo added the r+ 👌 label Feb 14, 2019

@pparidans

This comment has been minimized.

Copy link
Contributor

pparidans commented Feb 14, 2019

@robodoo rebase-merge

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 14, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 label Feb 14, 2019

robodoo added a commit that referenced this pull request Feb 14, 2019

[IMP] web: mobile kanban tabs UX
This merge change the mobile kanban tabs UX by allowing to scroll
through them and go directly from a column A to B. It also improve the
readability independently of the title's length.

This behavior is heavily inspired by Material Design.

See: https://material.io/design/components/tabs.html

It's also an opportunity to refactor the mobile kanban renderer code to make it
more robust and readable.

Task: 1893168

closes #29024
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 14, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 14, 2019

@res-odoo res-odoo deleted the odoo-dev:master-kanban-tab-mobile-text-res branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment