[IMP] account: add tax lock date #29272
Conversation
|
|
||
| def test_create_before_block_date(self): | ||
| self.user_id.company_id.tax_lock_date = self.last_day_month_str | ||
| with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
I'd rather have an invoice created with a single product line with a tax on it
There was a problem hiding this comment.
or both, but then, the with self.assertRaises(ValidationError): must be only on the move.post() line
There was a problem hiding this comment.
Does it make any difference since the constraint is
@api.constrains('credit', 'debit', 'tax_ids', 'tax_line_id', 'date')
No difference is made.
Also, the create should raise an error since the date of the move is before the lock date. Shouldn't it ?
There was a problem hiding this comment.
I was thinking that the constraint might be checked only on posted moves (so, upon posting, deleting/editing/creating a posted move) but I'm not sure anymore....
keep it as it, for now
william-andre
force-pushed
the
master-lock-date-wan
branch
from
5aa75b0
to
a4bcc95
Compare
robodoo
added
CI 🤖
william-andre
force-pushed
the
master-lock-date-wan
branch
from
a4bcc95
to
cecde72
Compare
robodoo
added
CI 🤖
william-andre
force-pushed
the
master-lock-date-wan
branch
from
cecde72
to
0e200a8
Compare
william-andre
force-pushed
the
master-lock-date-wan
branch
from
0e200a8
to
a5db1b9
Compare
robodoo
added
CI 🤖
| @@ -698,6 +698,14 @@ def default_get(self, fields): | |||
| rec.update({'credit': balance}) | |||
| return rec | |||
|
|
|||
| @api.multi | |||
| @api.constrains('credit', 'debit', 'tax_ids', 'tax_line_id', 'date') | |||
There was a problem hiding this comment.
that ain't working...
the implementation with a constraint will fail in the following use case:
- make an invoice with a tax
- set the tax lock date to include the invoice
- go on the invoice journal entry and remove the tax_ids or tax_line_id values (with account_cancel, or via the studio)
=> an error should be thrown but there isn't any since the test at line 705 is falsy
There was a problem hiding this comment.
I don't get how it is different from what is done in the tests? And the tests are green.
There was a problem hiding this comment.
because in my use case i'm modifying one of the field that composes the condition of L705, making it False where it was True before.
please, read again my use case
There was a problem hiding this comment.
Oh, right... I remember having thought about this though.
Updated, with the tests too.
william-andre
force-pushed
the
master-lock-date-wan
branch
from
ad95c83
to
c3bbc1e
Compare
robodoo
added
CI 🤖
Purpose:
Journal entry can be changed the way we want while the lock date is before then entry date..
Entry : Draft -> Validated (or posted)
Specs:
add a date field in the accounting settings: tax lock date
implement a constraint ensuring that no one can modify the information related to tax on account.move.line prior to this lock date. That means the debit, credit, tax_ids, tax_line_id fields. Other fields can be modified. This also means we cannot create/delete an account.move.line with tax information prior to this lock date.
Task 1914762
william-andre
force-pushed
the
master-lock-date-wan
branch
from
c3bbc1e
to
fe2eff0
Compare
robodoo
added
CI 🤖
|
@robodoo r+ |
Purpose:
Journal entry can be changed the way we want while the lock date is before then entry date..
Entry : Draft -> Validated (or posted)
Specs:
add a date field in the accounting settings: tax lock date
implement a constraint ensuring that no one can modify the information related to tax on account.move.line prior to this lock date. That means the debit, credit, tax_ids, tax_line_id fields. Other fields can be modified. This also means we cannot create/delete an account.move.line with tax information prior to this lock date.
Task 1914762
closes #29272
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
Merged, thanks! |
Description of the issue/feature this PR addresses:
Journal entry can be changed the way we want while the lock date is before then entry date
Current behavior before PR:
One can only change draft entries
Desired behavior after PR is merged:
One can change all entries provided the date is after the lock date
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr