New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] survey: properly inherit survey assets in website_survey module #29314

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@tde-banana-odoo
Contributor

tde-banana-odoo commented Dec 6, 2018

Purpose

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

@robodoo robodoo added the seen 🙂 label Dec 6, 2018

@awa-odoo awa-odoo force-pushed the odoo-dev:master-website-survey-fix-assets-inherit-awa branch from 38eb48c to ab309ff Dec 6, 2018

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 6, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes odoo#29314
@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 6, 2018

@robodoo robodoo added the r+ 👌 label Dec 6, 2018

@C3POdoo C3POdoo added the RD label Dec 6, 2018

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-website-survey-fix-assets-inherit-awa branch from ab309ff to 1300a7f Dec 7, 2018

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 7, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes odoo#29314

@robodoo robodoo removed the r+ 👌 label Dec 7, 2018

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 7, 2018

robodoo pushed a commit that referenced this pull request Dec 7, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes #29314

@robodoo robodoo added the merging 👷 label Dec 7, 2018

robodoo pushed a commit that referenced this pull request Dec 7, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes #29314

@awa-odoo awa-odoo force-pushed the odoo-dev:master-website-survey-fix-assets-inherit-awa branch from 1300a7f to ab309ff Dec 7, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes #29314

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-website-survey-fix-assets-inherit-awa branch from ab309ff to 3f954a6 Dec 7, 2018

@tde-banana-odoo

This comment has been minimized.

Contributor

tde-banana-odoo commented Dec 7, 2018

robodoo pushed a commit that referenced this pull request Dec 7, 2018

[FIX] survey: properly inherit survey assets in website_survey module
Purpose
=======

Survey assets were incorrectly overridden in the website_survey module and all copy/pasted.

This will correctly include the survey_assets template and get rid of these copy/pasted
assets references, while keeping the website style on survey pages.

Task: #1915790
closes #29314

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Dec 7, 2018

@robodoo

This comment has been minimized.

Contributor

robodoo commented Dec 7, 2018

Merged, thanks!

@robodoo robodoo closed this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment