New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]web: translation field warning method issue has been fixed #29377

Open
wants to merge 2 commits into
base: saas-11.3
from

Conversation

Projects
None yet
4 participants
@tsh-odoo
Copy link
Contributor

tsh-odoo commented Dec 10, 2018

Issue-Link: https://www.odoo.com/web#id=1877480&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Before this commit:
After translating any field, translation warning could not be opened for translation.

After this commit:
Translation can be done of any field from translation warning form view. History of multiple translation pages has also been maintained until page reload.

Issue-ID: 1877480

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Dec 10, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:saas-11.3-translation-issue-tsh branch from a879cf9 to aa1794a Jan 10, 2019

@robodoo robodoo added seen 🙂 CI 🤖 and removed CI 🤖 labels Jan 10, 2019

[IMP]web: translation issue fixed
Before this commit:
After transating any field -> clicking on transalation warning -> come back through breadcrumb do not preserve translation warning.

After this commit:
After transating any field -> clicking on transalation warning -> come back through breadcrumb preserves warning, warning alert remains there until view or record is changed.

alertFields is now object which stores tranlsation alerts per record, so changing record and come back to previous record for which alert fields are available then form renderer display those alert fields until form renderer is destroyed.

Issue-ID: 1877480

Co-authored-by: Mohammed Shekha <msh@openerp.com>

@msh-odoo msh-odoo force-pushed the odoo-dev:saas-11.3-translation-issue-tsh branch from 0d501b9 to 1f6cf1c Jan 11, 2019

@robodoo robodoo added the CI 🤖 label Jan 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment