Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: Mapping accounts #29433

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@switch87
Copy link
Contributor

switch87 commented Dec 11, 2018

accounts mapping of fiscal positions should work on the PoS as it works
in Sales

Description of the issue/feature this PR addresses:

Setup a fiscal position with account mapping for income account and
receivable account
Make a pos_order with the fiscal position

Current behavior before PR:

When pos is closed, account mapping is not done and the
account_move does not take the mapped income account nor
receivable account

Desired behavior after PR is merged:

The account_move should take the mapped income account
and receivable account

task:
https://www.odoo.com/web#id=1916865&action=333&active_id=1428&model=project.task&view_type=form&menu_id=4720

Original commit by @invitu

@robodoo robodoo added the seen 🙂 label Dec 11, 2018

@robodoo robodoo added the CI 🤖 label Dec 11, 2018

@switch87 switch87 force-pushed the odoo-dev:master-pos-account-mapping-on-fiscal-position-gpe branch Dec 13, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 13, 2018

@switch87 switch87 force-pushed the odoo-dev:master-pos-account-mapping-on-fiscal-position-gpe branch Jan 14, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 14, 2019

@switch87 switch87 force-pushed the odoo-dev:master-pos-account-mapping-on-fiscal-position-gpe branch Jan 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 22, 2019

@pha-odoo

This comment has been minimized.

Copy link

pha-odoo commented Feb 22, 2019

@qle-odoo ok to merge

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Feb 22, 2019

@robodoo robodoo added error 🙅 and removed CI 🤖 labels Feb 22, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Unable to stage PR ({"message":"Merge conflict","documentation_url":"https://developer.github.com/v3/repos/merging/#perform-a-merge"})

[IMP] point_of_sale: Mapping accounts
accounts mapping of fiscal positions should work on the PoS as it works
in Sales

Description of the issue/feature this PR addresses:

Setup a fiscal position with account mapping for income account and
receivable account
Make a pos_order with the fiscal position

Current behavior before PR:

When pos is closed, account mapping is not done and the
account_move does not take the mapped income account nor
receivable account

Desired behavior after PR is merged:

The account_move should take the mapped income account
and receivable account

task:
https://www.odoo.com/web#id=1916865&action=333&active_id=1428&model=project.task&view_type=form&menu_id=4720

@switch87 switch87 force-pushed the odoo-dev:master-pos-account-mapping-on-fiscal-position-gpe branch to 7e5dcb5 Feb 22, 2019

@switch87

This comment has been minimized.

Copy link
Contributor Author

switch87 commented Feb 22, 2019

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Feb 22, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

I'm sorry, @qle-odoo. This PR is already reviewed, reviewing it again is useless.

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Mar 1, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 1, 2019

I'm sorry, @qle-odoo. This PR is already reviewed, reviewing it again is useless.

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Mar 5, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 5, 2019

robodoo pushed a commit that referenced this pull request Mar 5, 2019

[IMP] point_of_sale: Mapping accounts
accounts mapping of fiscal positions should work on the PoS as it works
in Sales

Description of the issue/feature this PR addresses:

Setup a fiscal position with account mapping for income account and
receivable account
Make a pos_order with the fiscal position

Current behavior before PR:

When pos is closed, account mapping is not done and the
account_move does not take the mapped income account nor
receivable account

Desired behavior after PR is merged:

The account_move should take the mapped income account
and receivable account

task:
https://www.odoo.com/web#id=1916865&action=333&active_id=1428&model=project.task&view_type=form&menu_id=4720

closes #29433
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 5, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 5, 2019

@switch87 switch87 deleted the odoo-dev:master-pos-account-mapping-on-fiscal-position-gpe branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.